Get rid of useless SpotBugs suppressions

Author: uhafner

etc/assertj-templates/soft_assertions_entry_point_class_template.txt

@@ -3,7 +3,6 @@ package ${package};
 /**
  * Entry point for soft assertions of different data types.
  */
-@edu.umd.cs.findbugs.annotations.SuppressFBWarnings("NM")
 @edu.hm.hafner.util.Generated(value="assertj-assertions-generator")
 public class SoftAssertions extends org.assertj.core.api.AutoCloseableSoftAssertions {
 ${all_assertions_entry_points}

src/main/java/edu/hm/hafner/util/LineRangeList.java

@@ -1,5 +1,11 @@
 package edu.hm.hafner.util;
 
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
+
+import edu.umd.cs.findbugs.annotations.NonNull;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import edu.umd.cs.findbugs.annotations.SuppressMatchType;
+
 import java.io.Serial;
 import java.io.Serializable;
 import java.util.AbstractList;
@@ -12,11 +18,6 @@
 import java.util.NoSuchElementException;
 import java.util.stream.StreamSupport;
 
-import com.google.errorprone.annotations.CanIgnoreReturnValue;
-
-import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 /**
  * {@link List} of {@link LineRange} that stores values more efficiently at runtime.
  *
@@ -241,7 +242,8 @@ private void prev() {
          *
          * @return the current element
          */
-        @Override @SuppressFBWarnings(value = "IT_NO_SUCH_ELEMENT", justification = "thrown in read()")
+        @Override
+        @SuppressFBWarnings(value = ".*", justification = "thrown in read()", matchType = SuppressMatchType.REGEX)
         public LineRange next() {
             int s = read();
             int d = read();

src/main/java/edu/hm/hafner/util/SecureXmlParserFactory.java

@@ -1,9 +1,5 @@
 package edu.hm.hafner.util;
 
-import java.io.IOException;
-import java.io.Reader;
-import java.io.Serial;
-import java.nio.charset.Charset;
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
@@ -30,6 +26,11 @@
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
+import java.io.IOException;
+import java.io.Reader;
+import java.io.Serial;
+import java.nio.charset.Charset;
+
 import static javax.xml.XMLConstants.*;
 
 /**
@@ -318,7 +319,6 @@ private InputSource createInputSource(final Reader reader, final Charset charset
      *
      * @return the created {@link Transformer}
      */
-    @SuppressFBWarnings(value = {"XXE_DTD_TRANSFORM_FACTORY", "XXE_XSLT_TRANSFORM_FACTORY"}, justification = "The transformer is secured in the called method")
     public Transformer createTransformer() {
         try {
             var transformerFactory = createTransformerFactory();

src/test/java/edu/hm/hafner/util/AbstractEqualsTest.java

@@ -2,8 +2,6 @@
 
 import org.junit.jupiter.api.Test;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 import static org.assertj.core.api.Assertions.*;
 
 /**
@@ -23,7 +21,6 @@ public abstract class AbstractEqualsTest {
      * Verifies that for any non-null reference value {@code x}, {@code x.equals(null)} should return {@code false}.
      */
     @Test
-    @SuppressFBWarnings("EC")
     @SuppressWarnings({"PMD.EqualsNull", "checkstyle:equalsavoidnull", "ConstantConditions"})
     void shouldReturnFalseOnEqualsNull() {
         assertThat(createSut().equals(null)).isFalse();

src/test/java/edu/hm/hafner/util/PathUtilTest.java

@@ -1,15 +1,13 @@
 package edu.hm.hafner.util;
 
-import java.io.IOException;
-import java.nio.file.LinkOption;
-import java.nio.file.Path;
-
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import java.io.IOException;
+import java.nio.file.LinkOption;
+import java.nio.file.Path;
 
 import static org.assertj.core.api.Assertions.*;
 import static org.assertj.core.api.Assumptions.*;
@@ -19,7 +17,6 @@
  *
  * @author Ullrich Hafner
  */
-@SuppressFBWarnings("DMI")
 @SuppressWarnings("NullAway") // in tests, we do not care about null values when the path does not exist
 class PathUtilTest extends ResourceTest {
     private static final String NOT_EXISTING = "/should/not/exist";

src/test/java/edu/hm/hafner/util/ResourceTest.java

@@ -1,5 +1,11 @@
 package edu.hm.hafner.util;
 
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.io.input.BOMInputStream;
+import org.opentest4j.TestAbortedException;
+
+import com.google.errorprone.annotations.MustBeClosed;
+
 import java.io.BufferedReader;
 import java.io.File;
 import java.io.IOException;
@@ -12,14 +18,6 @@
 import java.nio.file.Path;
 import java.util.stream.Stream;
 
-import org.apache.commons.io.IOUtils;
-import org.apache.commons.io.input.BOMInputStream;
-import org.opentest4j.TestAbortedException;
-
-import com.google.errorprone.annotations.MustBeClosed;
-
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 import static org.assertj.core.api.Assumptions.*;
 
 /**
@@ -105,7 +103,6 @@ protected byte[] readAllBytes(final Path path) {
         }
     }
 
-    @SuppressFBWarnings("UI_INHERITANCE_UNSAFE_GETRESOURCE")
     private Path getPath(final String name) throws URISyntaxException {
         var resource = getTestResourceClass().getResource(name);
         ensureThatResourceExists(resource, name);

src/test/java/edu/hm/hafner/util/SerializableTest.java

@@ -1,5 +1,9 @@
 package edu.hm.hafner.util;
 
+import org.assertj.core.api.ObjectAssert;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
@@ -10,12 +14,6 @@
 import java.nio.file.Path;
 import java.nio.file.StandardOpenOption;
 
-import org.assertj.core.api.ObjectAssert;
-import org.junit.jupiter.api.DisplayName;
-import org.junit.jupiter.api.Test;
-
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
-
 import static org.assertj.core.api.Assertions.*;
 
 /**
@@ -121,7 +119,6 @@ protected byte[] toByteArray(final Serializable object) {
      * @throws IOException
      *         if the file could not be created
      */
-    @SuppressFBWarnings("DMI")
     protected void createSerializationFile() throws IOException {
         Files.write(Path.of("/tmp/serializable.ser"), toByteArray(createSerializable()),
                 StandardOpenOption.CREATE_NEW);