Skip to content

@angular/router module is required #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pshurygin opened this issue Aug 9, 2018 · 4 comments
Closed

@angular/router module is required #184

pshurygin opened this issue Aug 9, 2018 · 4 comments
Labels

Comments

@pshurygin
Copy link

I'm not sure if this is intended or not, but i cannot use angular-hybrid router without installing @angular/router as a dependancy. This results in a pretty large footprint of the router. (ui-router core + ui-router angular + ui-router angularjs + @angular/router). Here is a visualization:
image

And if I remove @angular/router from dependancy list, i get the following error on build(AOT):

ERROR in @uirouter\angular\lib\uiRouterNgModule.ts(67,16): Error during template compile of 'makeChildProviders'
Could not resolve @angular/router relative to D:/Solomoto/impl/solo/SolomotoWebRole/node_modules/@uirouter/angular/lib/uiRouterNgModule.d.ts..

@chce
Copy link

chce commented Aug 28, 2018

I found this comment by the ui-router developers while reading an issue on Angular's issue tracker:
angular/angular-cli#4541 (comment)

@pshurygin
Copy link
Author

Thanks, so that means it's angular devs to blame for that. And there is no progress on that issue whatsoever for already 1.5 years, so I guess we are just supposed to live with that extra 20kb of useless code for our clients.

@chce
Copy link

chce commented Aug 31, 2018

There is a bit of progress on a related issue, but it doesn't really seem like top priority: angular/angular-cli#9343

@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.
This does not mean that the issue is invalid. Valid issues
may be reopened.
Thank you for your contributions.

@stale stale bot added the stale label Nov 12, 2022
@stale stale bot closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants