-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(angular): Updates for Angular 7
As already sketched in #423, we are already using Angular 7 with uirouter/angular over at opf/openproject and meanwhile in production as well, so we can safely attest that the current version of uirouter works unchanged with even the recent Angular 7.2.2 release with only some minor hassle during the upgrade due to the peer depedndency. This PR tries to add the dependency and a downstream test. I had to bump the local typescript version to ensure RxJS is being built, without it `ngc` will output the following errors node_modules/rxjs/internal/types.d.ts(81,74): error TS1005: ';' expected. This is due to this issue: ReactiveX/rxjs#4511 Using the newest typescript also uncovered an issue in `uiSrefStatus.ts`. In all downstream tests with TS < 2.8., I pinned rxjs to avoid the same issue.
- Loading branch information
1 parent
960048e
commit 7f3132a
Showing
37 changed files
with
26,239 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.