Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect string escaping in TOML encoder #201

Open
ghost opened this issue Sep 30, 2018 · 1 comment · May be fixed by #244
Open

Incorrect string escaping in TOML encoder #201

ghost opened this issue Sep 30, 2018 · 1 comment · May be fixed by #244
Labels
component: encoder Related to serialising in `toml.dump` syntax: strings Related to string literals type: bug A confirmed bug or unintended behavior

Comments

@ghost
Copy link

ghost commented Sep 30, 2018 •
edited by ghost
Loading

While encoding string values, the TOML encoder incorrecty handles backslash characters that occur in the string value.

For example:

toml.dumps({"a": "\\x"})

returns

a = "\u00"

which is not valid TOML.

This bug also triggers failures in the encoder tests "escaped-escape" and "string-escapes" from the TOML test suite.
@Versatilus Versatilus mentioned this issue Dec 19, 2018
Closed
@LexiconCode
Copy link

LexiconCode commented Jan 5, 2019 •
edited
Loading

@uiri This bug is affecting two projects I am affiliated with Caster and Dragonfly.

@dbohdan dbohdan mentioned this issue Apr 25, 2019
Closed
@comodoro comodoro linked a pull request Apr 26, 2019 that will close this issue
Open
@erkyrath erkyrath mentioned this issue Apr 29, 2019
Open
@wbenny wbenny mentioned this issue Oct 19, 2019
Open
@pradyunsg pradyunsg added type: bug A confirmed bug or unintended behavior syntax: strings Related to string literals component: encoder Related to serialising in `toml.dump` labels Apr 20, 2022
@JamesParrott JamesParrott mentioned this issue Apr 26, 2023
Closed
@pirate pirate mentioned this issue Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: encoder Related to serialising in `toml.dump` syntax: strings Related to string literals type: bug A confirmed bug or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

String dump with correct escaping comodoro/toml
2 participants
@pradyunsg @LexiconCode