Add health check make command #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #28 |
tylerwoonton
changed the title
|
I've tested this on PHP 7.4 in a Laravel 5.5 app and it all works as expected. |
|
@miff2000 I'll ask someone to review this in the morning and then I'll merge it in. |
Gman98ish
force-pushed
the
30-add-health-check-make-command
branch
from
ccced7f to
88e4c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally force pushed to #30 and broke the diff so I've duplicated the code here.
I'll sort out the tests because I know the previous MR was having trouble so we can get this merged this week.