Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

The tag displaying countries are displaying country codes #62

Open
rahulbist opened this issue Apr 2, 2020 · 2 comments
Open

The tag displaying countries are displaying country codes #62

rahulbist opened this issue Apr 2, 2020 · 2 comments
Labels
bug Something isn't working Priority

Comments

@rahulbist
Copy link

The tag displaying countries within the Enquiry Management Tool should display country names and not the country code.

Additionally, it seems currently, we are outputting the country name for some and the country code for others:

image

@rahulbist rahulbist added the bug Something isn't working label Apr 2, 2020
@saruniitr
Copy link
Contributor

saruniitr commented Apr 2, 2020

This is mainly because of mismatch in reference data. The great website uses abbreviate country names for the choices but in our app we use full name.
When new enquiries are fetched from AS and parsed to create new instances currently we are not doing the mapping resulting in this bug.
Plan is to use the same reference data in our app also but directory-constants was not supporting Django 3 or higher which is required for us. A PR has been submitted and it is merged so we can take up that task and fix this issue. uktrade/directory-constants#133

@rahulbist
Copy link
Author

To complete this issue and resolve the bug, the outstanding task is to map the country codes obtained from great.gov.uk (https://www.registers.service.gov.uk/registers/country) and map these country codes to the country codes within the Enquiry Management Tool repo.

When the mapping is achieved, this will then eradicate the Enquiry Management Tool displaying country codes instead of the full country name

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Priority
Projects
None yet
Development

No branches or pull requests

2 participants