Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP 304 being returned - should these records be dropped? #40

Open
anjackson opened this issue Apr 30, 2019 · 1 comment
Open

HTTP 304 being returned - should these records be dropped? #40

anjackson opened this issue Apr 30, 2019 · 1 comment
Labels
question Further information is requested

Comments

@anjackson
Copy link
Contributor

anjackson commented Apr 30, 2019

We have a specific Twitter URL recorded as a 304 Not Modified (via a browser rendering cache checking event).

https://www.webarchive.org.uk/wayback/archive/20190312214115/https://ton.twimg.com/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js

it seems to be played back as a 304 rather than skipped. The CDX records look like

...
com,twimg,ton)/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js 20190312213613 https://ton.twimg.com/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js application/javascript 200 NMGUH2FASUEU67TMO7EM7Y7FJ7W5ZUNI 0
com,twimg,ton)/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js 20190312213614 https://ton.twimg.com/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js application/http 304 3I42H3S6NNFQ2MSVX7XZKYAYSCX5QBYJ 0
com,twimg,ton)/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js 20190312213615 https://ton.twimg.com/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js application/http 304 3I42H3S6NNFQ2MSVX7XZKYAYSCX5QBYJ 0
com,twimg,ton)/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js 20190312213616 https://ton.twimg.com/tfw/js/native_bundle_v1_2c6dc837d4dedb22fff5faf9e125064ba2cbeb8a.js application/http 304 3I42H3S6NNFQ2MSVX7XZKYAYSCX5QBYJ 0
...
@anjackson anjackson changed the title HTTP 304 being returned? HTTP 304 being returned -- Should these records be dropped? Nov 12, 2019
@anjackson anjackson changed the title HTTP 304 being returned -- Should these records be dropped? HTTP 304 being returned - should these records be dropped? Nov 12, 2019
@anjackson anjackson added the question Further information is requested label Nov 12, 2019
@anjackson
Copy link
Contributor Author

These should probably be filtered out during indexing, and/or when querying the index (as per #30). Not technically anything to so with PyWB itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant