Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: support faiss to enable efficient search #715

Closed
lwaekfjlk opened this issue Sep 29, 2024 · 5 comments
Closed

[FEAT]: support faiss to enable efficient search #715

lwaekfjlk opened this issue Sep 29, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@lwaekfjlk
Copy link
Member

Description

we should use faiss to accelerate

Additional Information

No response

@lwaekfjlk lwaekfjlk added the enhancement New feature or request label Sep 29, 2024
@shreypandey
Copy link
Contributor

Hi @lwaekfjlk,
Is FAISS integration required for accelerated retrieval of agent and paper retrieval?
If so, perhaps it could be achieved with an embedding database like Redis and creating appropriate ANN indexes on embeddings in that, as suggested in as mentioned in #430 .

Additionally, FAISS requires re-indexing whenever new embeddings are added, which could be managed asynchronously and more efficiently with an embedding database.

@lwaekfjlk
Copy link
Member Author

lwaekfjlk commented Oct 12, 2024

yes, @shreypandey, good point! thanks for mentioning that, you can check #431 that we include redis support in our roadmap of the 0.0.2 version. Looking forward to futher discussion.

@shreypandey
Copy link
Contributor

Hi @lwaekfjlk, I have proposed an implementation of redis integration on #428, Please review the proposed implementation.

@lwaekfjlk
Copy link
Member Author

sure.

@lwaekfjlk
Copy link
Member Author

this should be squashed together into #428. therefore, close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants