Save gas on IsFeeEnabled (backport cosmos#2786) (cosmos#2815)

mergify[bot] · ulbqb · commit 935de3aea8e0 · 2023-07-31T16:01:46.000+09:00
improvements: save some gas in fee keeper
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -44,6 +44,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### Improvements
 
+* (apps/29-fee) [\#2786](https://github.com/cosmos/ibc-go/pull/2786) Save gas by checking key existence with `KVStore`'s `Has` method.
+
 ### Features
 
 ### Bug Fixes
diff --git a/modules/apps/29-fee/keeper/keeper.go b/modules/apps/29-fee/keeper/keeper.go
@@ -121,7 +121,7 @@ func (k Keeper) DeleteFeeEnabled(ctx sdk.Context, portID, channelID string) {
 // fee enabled flag for the given port and channel identifiers
 func (k Keeper) IsFeeEnabled(ctx sdk.Context, portID, channelID string) bool {
 	store := ctx.KVStore(k.storeKey)
-	return store.Get(types.KeyFeeEnabled(portID, channelID)) != nil
+	return store.Has(types.KeyFeeEnabled(portID, channelID))
 }
 
 // GetAllFeeEnabledChannels returns a list of all ics29 enabled channels containing portID & channelID that are stored in state

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ func (k Keeper) DeleteFeeEnabled(ctx sdk.Context, portID, channelID string) {`
`121`	`121`	`// fee enabled flag for the given port and channel identifiers`
`122`	`122`	`func (k Keeper) IsFeeEnabled(ctx sdk.Context, portID, channelID string) bool {`
`123`	`123`	`store := ctx.KVStore(k.storeKey)`
`124`		`- return store.Get(types.KeyFeeEnabled(portID, channelID)) != nil`
	`124`	`+ return store.Has(types.KeyFeeEnabled(portID, channelID))`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`// GetAllFeeEnabledChannels returns a list of all ics29 enabled channels containing portID & channelID that are stored in state`