Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JVM shutdown hook to report the metrics from the current TimeWindow. #22

Open
smrutilal2 opened this issue Sep 3, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@smrutilal2
Copy link
Collaborator

Currently all the TimeWindow based reporter has to wait for the next time window to report the metrics. To make it work from a batch job or from a Lambda function, client will have to sleep for at least the reporting frequency (60 seconds by default) at the end of the job.

Instead we need to add a JVM shutdown hook that would flush and report the metrics from the current time window.

@smrutilal2 smrutilal2 added the enhancement New feature or request label Sep 3, 2019
@gilad-bendor
Copy link

I would suggest - as a solution - that the existing "com.yahoo.yamas.YamasReporter#close()" would flush the report before returning...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants