Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to submit a PR to ultrafunkamsterdam/nodriver #1956

Open
unixfox opened this issue Jul 21, 2024 · 2 comments
Open

Would like to submit a PR to ultrafunkamsterdam/nodriver #1956

unixfox opened this issue Jul 21, 2024 · 2 comments

Comments

@unixfox
Copy link

unixfox commented Jul 21, 2024

Hello @ultrafunkamsterdam,

I would like to submit a PR on https://github.com/ultrafunkamsterdam/nodriver for fixing the bugs #1949 and #1896

But you have restricted the interaction to contributors only.

Could you please add my modification to nodriver repository: unixfox/nodriver#1? Also, available as a git patch: https://github.com/unixfox/nodriver/pull/1.patch

Thank you

@stephanlensky
Copy link

Hey @unixfox, due to lack of maintenance on nodriver recently I have just created a fork here: https://github.com/stephanlensky/zendriver

Would love to have you contribute, feel free to submit a PR and I'll try to get it merged right away. Thanks!

@unixfox
Copy link
Author

unixfox commented Oct 28, 2024

Hello @stephanlensky, thank you for the invitation. Feel free to merge my PR into your fork.

For now I'm still going to use ultrafunkamsterdam/nodriver since it is still maintained (one month old) but my patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants