-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Thymeleaf 2.1 #26
Comments
+1 |
Hi, I changed the line responsible for the search fragment in DecoratorProcessor class. // Locate the decorator page
FragmentAndTarget fragmentandtarget = StandardFragmentProcessor.computeStandardFragmentSpec(
arguments.getConfiguration(), arguments, element.getAttributeValue(attributeName),
null, null, false); My version: // Locate the decorator page
StandardFragment fragmentandtarget = StandardFragmentProcessor.computeStandardFragmentSpec(
arguments.getConfiguration(), arguments, element.getAttributeValue(attributeName),
null); With this change the layout dialect work with Thymeleaf 2.1 milestones. |
Yup, that'll work for that class, although I think it fails for the include/replace processors (tests fail). There are some upcoming changes to this API in 2.1-beta2 though, which I think will let that line of code work without any modification, so I'm waiting on those before deciding what to do. |
For anybody following this issue, I've just uploaded a 1.2-SNAPSHOT version built against Thymeleaf 2.1.0-beta2. |
Where can we find the binary for your 1.2-SNAPSHOT? The pages say check the master but that looks like its still configured for thymeleaf 2.0.x. Thanks |
The Maven snapshots repository is browsable, so you can get the binaries from there: https://oss.sonatype.org/content/repositories/snapshots/ Just to save you the trouble though, here are the binary, javadoc, and source JARs for the 1.2-SNAPSHOT I uploaded last week:
|
Ah of course I forgot about the sonatype one. Thanks that's great |
Thanks a lot for your contribution Emanue. It's great! |
Putting together the 1.2 release now that Thymeleaf 2.1 is out. |
Thymeleaf 2.1 milestones are out, so I should create a version of the layout dialect that can work with it.
I tried to use it just now and it seems I'm using some methods that were removed, so hopefully that's all I need to fix up.
The text was updated successfully, but these errors were encountered: