Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Thymeleaf 2.1 #26

Closed
ultraq opened this issue Sep 1, 2013 · 9 comments
Closed

Support for Thymeleaf 2.1 #26

ultraq opened this issue Sep 1, 2013 · 9 comments
Assignees

Comments

@ultraq
Copy link
Owner

ultraq commented Sep 1, 2013

Thymeleaf 2.1 milestones are out, so I should create a version of the layout dialect that can work with it.

I tried to use it just now and it seems I'm using some methods that were removed, so hopefully that's all I need to fix up.

@ghost ghost assigned ultraq Sep 1, 2013
@stomac
Copy link

stomac commented Sep 14, 2013

+1

@4ib3r
Copy link

4ib3r commented Sep 30, 2013

Hi, I changed the line responsible for the search fragment in DecoratorProcessor class.
Old version:

// Locate the decorator page
FragmentAndTarget fragmentandtarget = StandardFragmentProcessor.computeStandardFragmentSpec(
                arguments.getConfiguration(), arguments, element.getAttributeValue(attributeName),
                null, null, false);

My version:

// Locate the decorator page
StandardFragment fragmentandtarget = StandardFragmentProcessor.computeStandardFragmentSpec(
                arguments.getConfiguration(), arguments, element.getAttributeValue(attributeName),
                null);

With this change the layout dialect work with Thymeleaf 2.1 milestones.

@ultraq
Copy link
Owner Author

ultraq commented Sep 30, 2013

Yup, that'll work for that class, although I think it fails for the include/replace processors (tests fail). There are some upcoming changes to this API in 2.1-beta2 though, which I think will let that line of code work without any modification, so I'm waiting on those before deciding what to do.

@ultraq
Copy link
Owner Author

ultraq commented Oct 8, 2013

For anybody following this issue, I've just uploaded a 1.2-SNAPSHOT version built against Thymeleaf 2.1.0-beta2.

@BitResolution
Copy link

Where can we find the binary for your 1.2-SNAPSHOT? The pages say check the master but that looks like its still configured for thymeleaf 2.0.x. Thanks

@BitResolution
Copy link

Ah of course I forgot about the sonatype one. Thanks that's great

@ghost
Copy link

ghost commented Oct 21, 2013

Thanks a lot for your contribution Emanue. It's great!

@ultraq
Copy link
Owner Author

ultraq commented Nov 4, 2013

Putting together the 1.2 release now that Thymeleaf 2.1 is out.

@ultraq ultraq closed this as completed Nov 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants