Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window is not defined #21

Closed
mofux opened this issue Oct 12, 2017 · 3 comments
Closed

window is not defined #21

mofux opened this issue Oct 12, 2017 · 3 comments

Comments

@mofux
Copy link
Contributor

mofux commented Oct 12, 2017 •
edited
Loading

When using this module through node.js, some of the checks for window do fail. The reason is that checking the existence of a global window object cannot be done via if (window), because if window does not exist, it will throw an error. Instead, you should check for window existence via if (typeof window === 'object'), which will not throw.

I'm happy to create a PR if you like.
@mofux mofux changed the title window is not a function window is not defined Oct 12, 2017
@mofux
Copy link
Contributor Author

mofux commented Oct 12, 2017

To be a bit more precise, this only happens when using modifiers in the template, because then the the failing code is executed.

@mofux mofux mentioned this issue Oct 12, 2017
Merged
@mofux
Copy link
Contributor Author

mofux commented Oct 12, 2017

Created PR #22 that should solve the problems.

@umakantp
Copy link
Owner

Thanks for filling the issue @mofux and creating the PR. I will review and take a merge and release the new minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@umakantp @mofux