Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a click event is bubbled from its children, it will not be tracked #2471

Closed
CNSeniorious000 opened this issue Jan 14, 2024 · 1 comment
Closed
Labels
bug Something isn't working fixed in dev Fixed in the dev branch

Comments

@CNSeniorious000
Copy link

Describe the feature or enhancement

If my DOM is like this:

<button data-umami-event="btn">
  <div>some icon</div>
<button>

If I clicked on the div (which is often), this event will not be raised. I think this is a common case.

Of course I can trigger an window?.umami.track manually in onclick function, but I think this enhancement is beneficial in most cases.

@CNSeniorious000 CNSeniorious000 changed the title If a click event is bubbled, it will not be tracked If a click event is bubbled from its children, it will not be tracked Jan 14, 2024
@mikecao mikecao added the bug Something isn't working label Jan 15, 2024
@mikecao
Copy link
Collaborator

mikecao commented Jan 15, 2024

Confirmed, we'll get this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Fixed in the dev branch
Projects
None yet
Development

No branches or pull requests

2 participants