Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REMOVE_TRAILING_SLASH behaves "unexpected" #2592

Closed
profhase opened this issue Mar 12, 2024 · 1 comment
Closed

REMOVE_TRAILING_SLASH behaves "unexpected" #2592

profhase opened this issue Mar 12, 2024 · 1 comment
Labels
bug Something isn't working fixed in dev Fixed in the dev branch

Comments

@profhase
Copy link

Describe the Bug

The code

      if (process.env.REMOVE_TRAILING_SLASH) {
        urlPath = urlPath.replace(/.+\/$/, '');
      }

from

umami/src/pages/api/send.ts

Line 113 in a2245ef

if (process.env.REMOVE_TRAILING_SLASH) {
leads to issue: #2385 : It does not only remove the trailing slash but also everything before it. (Also see

https://umami.is/docs/environment-variables

)

Database

PostgreSQL

Relevant log output

No response

Which Umami version are you using? (if relevant)

newest

Which browser are you using? (if relevant)

any

How are you deploying your application? (if relevant)

No response
@profhase profhase changed the title removeTrailingSlash is "unexpected" REMOVE_TRAILING_SLASH behaves "unexpected" Mar 12, 2024
@mikecao mikecao added the bug Something isn't working label Mar 12, 2024
@franciscao633 franciscao633 added the fixed in dev Fixed in the dev branch label Mar 12, 2024
@franciscao633
Copy link
Collaborator

Fixed in v2.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed in dev Fixed in the dev branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikecao @profhase @franciscao633