Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completely redundant large dependency #2623

Closed
boehs opened this issue Mar 23, 2024 · 5 comments
Closed

completely redundant large dependency #2623

boehs opened this issue Mar 23, 2024 · 5 comments
Labels
fixed in dev Fixed in the dev branch

Comments

@boehs
Copy link

boehs commented Mar 23, 2024 •
edited
Loading

Describe the Bug

The timezone picker requires downloading 30kb of gzipped json the browser already has from another library. Fixing this is a 2 line change:

image

image

boehs/miami@f07058e
@boehs
Copy link
Author

boehs commented Mar 23, 2024 •
edited
Loading

image

I also got rid of moment-timezones on the frontend, saving another 30kb: boehs/miami@1f21b10

@boehs
Copy link
Author

boehs commented Mar 23, 2024 •
edited
Loading

Screen.Recording.Mar.22.at.10.mov

also it seems like the timezone picker doesn't even do anything (I am running ^ video on an instance of umami I haven't touched)

@boehs
Copy link
Author

boehs commented Mar 23, 2024

before vs after
image
image
it's still not good but it's less not bad

@mikecao
Copy link
Collaborator

mikecao commented Mar 23, 2024

Would welcome a PR for this.

@mikecao mikecao added the fixed in dev Fixed in the dev branch label Mar 29, 2024
@franciscao633
Copy link
Collaborator

Fixed in release v2.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed in dev Fixed in the dev branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikecao @franciscao633 @boehs