Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization options do work not in Chrome, mostly #20

Closed
yohanboniface opened this issue May 24, 2013 · 11 comments
Closed

Customization options do work not in Chrome, mostly #20

yohanboniface opened this issue May 24, 2013 · 11 comments
Labels

Comments

@yohanboniface
Copy link
Member

Originally reported by: BitBucket: positron96, GitHub: positron96


I am trying to create a map on http://umap.openstreetmap.fr using Chrome, and it seems I cannot change color of any object (either line, polygon or marker), and all of the marker properties (shape and symbol). Specifically, the gui shows me a color table to choose something, or a list of available marker shapes, but clicking on them does not change anything.


@yohanboniface
Copy link
Member Author

Original comment by Yohan Boniface (BitBucket: yohanboniface, GitHub: yohanboniface):


It's working here with Chrome, so we will have to dig a little bit more.

First questions:

@yohanboniface
Copy link
Member Author

Original comment by BitBucket: positron96, GitHub: positron96:


Hello there.
My Chrome is 25.0.1364.97 (build 183676) Windows XP x86

Just tried umap.fluv.io, I can change shape and symbol of the marker, but color modification works 1 time out of about 5.

@yohanboniface
Copy link
Member Author

Original comment by Yohan Boniface (BitBucket: yohanboniface, GitHub: yohanboniface):


Aïe, Windows.

I don't have any Windows to test on...

Any message in your js console?

@yohanboniface
Copy link
Member Author

Original comment by BitBucket: positron96, GitHub: positron96:


Nope, nothing interesting, only ```draw:created
Object {layer: NewClass, layerType: "marker", type: "draw:created", target: NewClass}


If that helps, after I click on the color table and it disappears, some text below gets selected, as if I dragged mouse from color button downwards

@yohanboniface
Copy link
Member Author

Original comment by Yohan Boniface (BitBucket: yohanboniface, GitHub: yohanboniface):


Humm, ok, I need to find a way to get closer to a Windows thing ;)

@yohanboniface
Copy link
Member Author

Original comment by BitBucket: positron96, GitHub: positron96:


Just checked Chromium 25.0.1364.160 (Developer Build 25.0.1364.160-0ubuntu0.12.04.1) Ubuntu 12.04
Color picking works much more reliably, but not in 100% of cases. I'd say about 80-90% My guess is that is was implemented via some kind of dirty hack which is unstable=)

@yohanboniface
Copy link
Member Author

Original comment by Yohan Boniface (BitBucket: yohanboniface, GitHub: yohanboniface):


I can change the colour 30 times on Chromium/Ubuntu, I have absolutely no bug :/

And without being able to reproduce it, I will not be able to fix it :(

Fortunatelly, I may have diner at my grand mother this week-end, and she runs on the Windows thing. So I will make some tests.

BTW, about "dirty hacks", feel free to patch, it's open source.

@yohanboniface
Copy link
Member Author

Original comment by BitBucket: positron96, GitHub: positron96:


Hello there. Sorry for mentioning "dirty hacks", I did not mean to hurt your feelings.

I am in no way a python-django developer, so I will do what I can do - debug javascript code in browser. Chrome could not produce a human-readable javascript from uMap, so I tried Opera (Color selection does not work in Opera as well). It's strange, but event handler for the contents of color picker

is not called every time I click on the elements. Sometimes it does, but very rarely - in this case everything works fine.

@yohanboniface
Copy link
Member Author

Original comment by Yohan Boniface (BitBucket: yohanboniface, GitHub: yohanboniface):


@positron96 can you test again on the http://umap.fluv.io instance?

Some friend of mines have been able to reproduce it, and while discussing with him on IRC I think I've found the problem. And so I've changed a "click" event by a "mousedown" event, and it seem fixed for him. Can you confirm?

Thanks for your report anyway!

@yohanboniface
Copy link
Member Author

Original comment by BitBucket: positron96, GitHub: positron96:


Hello Yohan.
Yes, I confirm that the bug is gone, both in Chrome and Opera! Great Job!

@yohanboniface
Copy link
Member Author

Original comment by Yohan Boniface (BitBucket: yohanboniface, GitHub: yohanboniface):


Great news! I can now pack and release the 0.3 so :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant