V15: Support Async for PackageMigrationPlans

[warrenbuckley]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0

Bug summary

As most of the Services & APIs in Umbraco are starting to go async it would be good to have PackageMigrationPlan have an async method to override for Migrate method.

Specifics

No response

Steps to reproduce

using Microsoft.Extensions.Options;
using Umbraco.Cms.Core.Configuration.Models;
using Umbraco.Cms.Core.IO;
using Umbraco.Cms.Core.PropertyEditors;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Strings;
using Umbraco.Cms.Infrastructure.Migrations;
using Umbraco.Cms.Infrastructure.Packaging;

namespace ExaminePeek.PackageMigrations.Migrations
{
	public class AddUserPermissionToAdmins : PackageMigrationBase
	{
		private readonly IUserGroupService _userGroupService;
		private readonly IUserService _userService;

		public AddUserPermissionToAdmins(IPackagingService packagingService, 
			IMediaService mediaService, 
			MediaFileManager mediaFileManager, 
			MediaUrlGeneratorCollection mediaUrlGenerators, 
			IShortStringHelper shortStringHelper, 
			IContentTypeBaseServiceProvider contentTypeBaseServiceProvider, 
			IMigrationContext context, 
			IOptions<PackageMigrationSettings> packageMigrationsSettings,
			IUserGroupService userGroupService,
			IUserService userService) 
			: base(packagingService, mediaService, mediaFileManager, mediaUrlGenerators, shortStringHelper, contentTypeBaseServiceProvider, context, packageMigrationsSettings)
		{
			_userGroupService = userGroupService;
			_userService = userService;
		}

		protected override async Task Migrate()
		{
			var adminGroup = await _userGroupService.GetAsync("AdminGroup");

			// Do stuff with admin group - add a new permission
		}

	}
}

Expected result / actual result

Allow me to use async APIs without having to add .Result inside the package migration 🤮

[github-actions[bot]]

Hi there @warrenbuckley!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nikolajlauridsen]

Hey @warrenbuckley, seems like a reasonable request to me, but since this is a feature request I'll go ahead and convert it to a discussion 😄

[warrenbuckley]

OK hopefully it does land over here and get forgotten about...