Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker not saving data #16779

Closed
lars-lindstrom opened this issue Jul 14, 2024 · 6 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#2115
Closed

Date Picker not saving data #16779

lars-lindstrom opened this issue Jul 14, 2024 · 6 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#2115

Comments

@lars-lindstrom
Copy link

lars-lindstrom commented Jul 14, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.1.0

Bug summary

I have created a document type to represent a person. The document type inherits a composition "Person composition" which includes an invariant "birthdate" property of type "Date Picker".

The document type and composition was created using version 14.0.0, but since upgrading to version 14.1.0 both new and updated values are no longer saved. Infact any value is deleted when updating any value of other properties of the document type.

Specifics

https://nxtlevelsport.dk/athletes/andreas-bock/

Birthdate "Født" shows 01 jan. 0001 and in the backoffice "dd-mm-yyyy" is shown when refreshing data.

Steps to reproduce

Video.uden.titel.mp4

Expected result / actual result

I expected the updated date to be saved.


This item has been added to our backlog AB#42326

Copy link

Hi there @lars-lindstrom!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@lars-lindstrom
Copy link
Author

After investigating the issue further, it seems the property value is not saved in the DB table "umbracoPropertyData". All other properties are updated and stored

@iOvergaard
Copy link
Contributor

This sounds serious. Thanks for testing, @lars-lindstrom. We'll make sure to investigate this.

@iOvergaard iOvergaard added state/needs-investigation This requires input from HQ or community to proceed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks affected/v14 labels Jul 15, 2024
@iOvergaard
Copy link
Contributor

Looking into this, I can reproduce the behavior if the format of the Date Picker does not match that which the server expects. For example, if configured as a date-only picker with YYYY-mm-dd, then the server cannot convert the value because the time string is missing. Conversely, if configured as a time-only picker with HH:mm:ss, then the server lacks the date part.

The only thing that works right now is the full string YYYY-mm-dd HH:mm:ss.

A fix has been started and we'll see how soon we can get it out.

@iOvergaard iOvergaard added state/reproduced area/frontend release/14.1.1 and removed state/needs-investigation This requires input from HQ or community to proceed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels Jul 15, 2024
@lars-lindstrom
Copy link
Author

Great work @iOvergaard !!

I have temporarily changed my site to use the Date with Time picker and it works as expected.
A thought, I recall a similar issue occured in v13.x (I cannot recall the actual version). Maybe some legacy code was not applied to v14.

@iOvergaard
Copy link
Contributor

Thanks, @lars-lindstrom!

Here is the plan: We are going to release a patch as soon as possible: 14.1.1. It will contain this fix as well as a few others we are looking into. I suspect we can get it out this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants