Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live editing mode not working for blocklist and blockgrid #17274

Closed
kasparboelkjeldsen opened this issue Oct 14, 2024 · 5 comments · Fixed by #17578
Closed

Live editing mode not working for blocklist and blockgrid #17274

kasparboelkjeldsen opened this issue Oct 14, 2024 · 5 comments · Fixed by #17578

Comments

@kasparboelkjeldsen
Copy link
Contributor

kasparboelkjeldsen commented Oct 14, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0-rc1

Bug summary

Making a change in the editor for a blocklist or blockgrid block, does not trigger UMB_PROPERTY_CONTEXT or UMB_BLOCK_ENTRY_CONTEXT and no change is observed until you hit the Update button, even though Live editing mode is enabled for the datatype.

Specifics

This works in v14

this.consumeContext(UMB_BLOCK_GRID_ENTRY_CONTEXT, (context) => {
      context.contentValues().then((content) => {
        this.observe(content, (content) => {
          console.log('content', content);
        });
      });
    });

I would expect this console.log to get hit when making a change (ie. writing a piece of text in a textbox or what have you) when editing a block. But nothing happens until you hit the update button.

Steps to reproduce

Create a custom view for a blockgrid or list, and consume contexts like in the example above.

Expected result / actual result

I would expect, observing either all the content in a block, or the value of the entiry property that -something- should update when I make a change, after having enabled live editing.


This item has been added to our backlog AB#45805

Copy link

Hi there @kasparboelkjeldsen!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@kasparboelkjeldsen
Copy link
Contributor Author

@iOvergaard @nielslyngsoe sorry but this still seems to be an issue in rc3.

this.consumeContext(UMB_PROPERTY_CONTEXT, (propertyContext) => {
      this.observe(propertyContext.value, (value) => {
        console.log('this should fire when I make a live change?')
      });
});
....
this.consumeContext(UMB_BLOCK_ENTRY_CONTEXT, async (context) => {
    context.contentValues().then(async (blockContent) => {
        this.observe(blockContent, async (content) => {
          console.log('this should change when I edit my block no?')
        });
      });
});
        ```
        
        These only fire after I hit the submit button on the blockgrid modal

@nielslyngsoe
Copy link
Member

Hi @kasparboelkjeldsen Thanks for reporting, I can also confirm that it does not work in 15.next.
We will make sure it does, thanks again.

@nielslyngsoe nielslyngsoe reopened this Nov 11, 2024
@nielslyngsoe nielslyngsoe added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Nov 11, 2024
@nielslyngsoe nielslyngsoe self-assigned this Nov 11, 2024
@asawyermarathon
Copy link
Contributor

asawyermarathon commented Nov 18, 2024

This may be the same / similar issue: I just noticed that listening for settingsValues() changes never fires either in 15.0.0:

blockEntryContext.settingsValues().then(async (blockSettings) => {
    console.log("settingsValues", blockSettings);
    blockEntryContext.observe(blockSettings, async (settings) => {
        console.log('this should change when I edit my block setttings no?')
    });
});

@madsrasmussen
Copy link
Contributor

Fixed by: #17578

@madsrasmussen madsrasmussen linked a pull request Nov 20, 2024 that will close this issue
1 task
@iOvergaard iOvergaard removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Nov 20, 2024
@nielslyngsoe nielslyngsoe changed the title v15.0-rc1 Live editing mode not working for blocklist and blockgrid Live editing mode not working for blocklist and blockgrid Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants