Custom Product Adapter & Snapshot not working as it did in Vendr

[redmorello]

I'm migrating a working Umbraco V8 & Vendr website over to Umbraco 13.5.2 & Commerce 13.1.13

I've followed the documentation here: https://docs.umbraco.com/umbraco-commerce/key-concepts/product-adapters and tweaked our existing CustomProductAdapter & CustomProductSnapshot

It's being added inside the IUmbracoCommerceBuilder:
builder.Services.AddUnique<ProductAdapterBase, CustomProductAdapter>();

The CustomProductAdapter has been changed to inherit from ProductAdapterBase:

public abstract class CustomProductAdapter : ProductAdapterBase
{
    private readonly ILogger<CustomProductAdapter> _logger;
    private readonly ICommerceService _commerceService;
    private readonly IPriceService _priceService;

    public CustomProductAdapter(
        ICommerceService commerceService,
        ILogger<CustomProductAdapter> logger,
        IPriceService priceService)
    {
        _commerceService = commerceService;
        _logger = logger;
        _priceService = priceService;
    }

    public IProductSnapshot? GetProductSnapshot(Guid storeId, string productReference, string languageIsoCode)
    {
        try
        {
            var snapshot = base.GetProductSnapshot(storeId, productReference, languageIsoCode);
            var sku = _commerceService.GetSku(snapshot.ProductReference, null);

            return snapshot != null
                ? new CustomProductSnapshot(storeId, sku, productReference, null, languageIsoCode, _priceService,
                    _logger)
                : null;
        }
        catch (Exception e)
        {
            _logger.LogError(e, e.Message);
        }

        return null;
    }

    public override IProductSnapshot? GetProductSnapshot(Guid storeId, string productReference, string productVariantReference, string languageIsoCode)
    {
        try
        {
            IProductSnapshot snapshot;
            var sku = _commerceService.GetSku(productReference, productVariantReference);

            snapshot = GetProductSnapshot(storeId, productReference, languageIsoCode);

            // if no snapshot has been found, thats because its a configurable or non-configurable product and the SKU is passed in via the productVariantReference
            if (snapshot == null)
            {
                //var umbracoProductSnapshot = new UmbracoProductSnapshot(GetPublishedContent(productReference), languageIsoCode, productReference);
                var customProductSnapshot = new CustomProductSnapshot(storeId, sku, productReference,
                    productVariantReference, languageIsoCode, _priceService, _logger);
                return customProductSnapshot;
            }

            return snapshot != null
                ? new CustomProductSnapshot(storeId, sku, productReference, null, languageIsoCode, _priceService,
                    _logger)
                : null;
        }
        catch (Exception e)
        {
            _logger.LogError(e, e.Message);
        }

        return null;
    }

    public override bool TryGetProductReference(Guid storeId, string sku, out string productReference,
        out string productVariantReference)
    {
        throw new NotImplementedException();
    }

    public PagedResult<IProductSummary> SearchProductSummaries(Guid storeId, string languageIsoCode,
        string searchTerm, long currentPage = 1,
        long itemsPerPage = 50)
    {
        throw new NotImplementedException();
    }

    public IEnumerable<Attribute> GetProductVariantAttributes(Guid storeId, string productReference,
        string languageIsoCode)
    {
        throw new NotImplementedException();
    }

    public PagedResult<IProductVariantSummary> SearchProductVariantSummaries(Guid storeId, string productReference,
        string languageIsoCode,
        string searchTerm, IDictionary<string, IEnumerable<string>> attributes, long currentPage = 1,
        long itemsPerPage = 50)
    {
        throw new NotImplementedException();
    }
}

but when adding a product to the cart, we're getting a pricing error, but also, we're not hitting the custom adapter when debugging. Have we missed a step somewhere?

[mattbrailsford]

Can you show me the code where you are calling AddUmbracoCommerce?

[redmorello]

Ah, of course I'm an idiot, we have our custom services added to DI in a composer, which now follows this code...

[redmorello]

Hmm, still an issue when moving Services inside their own UmbracoBuilder

builder.CreateUmbracoBuilder()
    .AddBackOffice()
    .AddWebsite()
    .AddServicesDependencies() - moved any Services from the composer to here 
    // any custom Commerce stuff needs to be before AddComposers
    .AddUmbracoCommerce(umbracoCommerceBuilder =>
    {
        umbracoCommerceBuilder.AddCommerceDependencies();
    })
    .AddComposers()
    .ConfigureAuthenticationMembers()
    .AddAzureBlobMediaFileSystem()
    .AddAzureBlobFileSystem("Forms")
    .AddAzureBlobImageSharpCache()
    .AddCdnMediaUrlProvider(options =>
    {
        options.Url = new Uri("https://xxxx.blob.core.windows.net/");
        options.RemoveMediaFromPath = false;
    })
    .Build();

Unhandled exception. System.ArgumentException: Cannot instantiate implementation type 'xxxx.Web.Global.Core.Commerce.CustomProductAdapter' for service type 'Umbraco.Commerce.Core.Adapters.ProductAdapterBase'.
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.Populate()
at Microsoft.Extensions.DependencyInjection.ServiceProvider..ctor(ICollection`1 serviceDescriptors, ServiceProviderOptions options)
at Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(IServiceCollection services, ServiceProviderOptions options)
at Jumoo.TranslationManager.Serializers.Boot.TranslationSerializerBootProcess.Boot(IUmbracoBuilder builder)
at Jumoo.TranslationManager.Serializers.Boot.TranslationSerializerBootExtension.AddTranslationSerializers(IUmbracoBuilder builder)
at Jumoo.TranslationManager.Serializers.Boot.TranslationSerializerComposer.Compose(IUmbracoBuilder builder)
at Umbraco.Cms.Core.Composing.ComposerGraph.Compose()
at Umbraco.Cms.Core.DependencyInjection.UmbracoBuilderExtensions.AddComposers(IUmbracoBuilder builder)
at Program.

$(String[] args) in C:\Projects\xxxx\xxxx.Web.Global_v13\xxxx.Web.Global.UmbracoCMS\Program.cs:line 39
at Program.(String[] args)

[redmorello]

This is the trimmed down CustomProductAdapter

Its the same error if I remove all injected services at the top

public abstract class CustomProductAdapter : ProductAdapterBase
{
    private readonly ILogger<CustomProductAdapter> _logger;
    private readonly ICommerceService _commerceService;
    private readonly IPriceService _priceService;

    public CustomProductAdapter(
        ICommerceService commerceService,
        ILogger<CustomProductAdapter> logger,
        IPriceService priceService)
    {
        _commerceService = commerceService;
        _logger = logger;
        _priceService = priceService;
    }

    public IProductSnapshot GetProductSnapshot(Guid storeId, string productReference, string languageIsoCode)
    {
        try
        {
            var snapshot = base.GetProductSnapshot(storeId, productReference, languageIsoCode);
            var sku = _commerceService.GetSku(snapshot.ProductReference, null);

            return snapshot != null
                ? new CustomProductSnapshot(storeId, sku, productReference, null, languageIsoCode, _priceService,
                    _logger)
                : null;
        }
        catch (Exception e)
        {
            _logger.LogError(e, e.Message);
        }

        return null;
    }

    public override IProductSnapshot GetProductSnapshot(Guid storeId, string productReference, string productVariantReference, string languageIsoCode)
    {
        try
        {
            IProductSnapshot snapshot;
            var sku = _commerceService.GetSku(productReference, productVariantReference);

            snapshot = GetProductSnapshot(storeId, productReference, languageIsoCode);

            // if no snapshot has been found, thats because its a configurable or non-configurable product and the SKU is passed in via the productVariantReference
            if (snapshot == null)
            {
                //var umbracoProductSnapshot = new UmbracoProductSnapshot(GetPublishedContent(productReference), languageIsoCode, productReference);
                var customProductSnapshot = new CustomProductSnapshot(storeId, sku, productReference,
                    productVariantReference, languageIsoCode, _priceService, _logger);
                return customProductSnapshot;
            }

            return snapshot != null
                ? new CustomProductSnapshot(storeId, sku, productReference, null, languageIsoCode, _priceService,
                    _logger)
                : null;
        }
        catch (Exception e)
        {
            _logger.LogError(e, e.Message);
        }

        return null;
    }
}

[redmorello]

@mattbrailsford found the issue, somewhere the word 'abstract' had crept into the adapter class. This was causing the DI issue.

I also had to change this:
builder.Services.AddUnique<ProductAdapterBase, CustomProductAdapter>();
to this:
builder.Services.AddUnique<IProductAdapter, CustomProductAdapter>();

otherwise the adapter never got found

[mattbrailsford]

Yup, I was just about to say the latter. You need to inherit the base class, but you need to register it with the di container via the interface so that should be correct now 👍🏻