Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom config files #6142

Merged
merged 3 commits into from
Feb 23, 2021
Merged

feat: support custom config files #6142

merged 3 commits into from
Feb 23, 2021

Conversation

chemdemo
Copy link
Contributor

@chemdemo chemdemo commented Feb 10, 2021

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Service类支持传入自定义的配置文件:

new Service({ configFiles: ['.mycustomrc.ts', 'config/mycustomrc.ts'] })

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #6142 (448750e) into master (e46701e) will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6142      +/-   ##
==========================================
+ Coverage   83.20%   83.24%   +0.03%     
==========================================
  Files         158      158              
  Lines        3502     3510       +8     
  Branches      942      946       +4     
==========================================
+ Hits         2914     2922       +8     
  Misses        578      578              
  Partials       10       10              
Impacted Files Coverage Δ
packages/core/src/Config/Config.ts 62.99% <75.00%> (+1.20%) ⬆️
packages/core/src/Service/Service.ts 96.34% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46701e...448750e. Read the comment docs.

Copy link
Contributor

@ycjcl868 ycjcl868 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档 API 需要补下

@chemdemo
Copy link
Contributor Author

api文档已更新。

@chemdemo chemdemo requested a review from ycjcl868 February 22, 2021 10:20
Copy link
Contributor

@ycjcl868 ycjcl868 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants