Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce the chance of regenerating conventional routes #6220

Merged
merged 2 commits into from
Mar 7, 2021

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Mar 7, 2021

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #6220 (52ebed8) into master (fb11c40) will decrease coverage by 0.41%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6220      +/-   ##
==========================================
- Coverage   85.15%   84.73%   -0.42%     
==========================================
  Files         152      152              
  Lines        3429     3453      +24     
  Branches      924      938      +14     
==========================================
+ Hits         2920     2926       +6     
- Misses        499      517      +18     
  Partials       10       10              
Impacted Files Coverage Δ
packages/core/src/Html/Html.ts 75.75% <11.11%> (-4.03%) ⬇️
...set-built-in/src/plugins/commands/generateFiles.ts 37.50% <23.07%> (-8.34%) ⬇️
...-built-in/src/plugins/generateFiles/core/routes.ts 63.15% <46.15%> (-24.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb11c40...52ebed8. Read the comment docs.

@sorrycc sorrycc changed the title feat: reduce the change of regenerating conventional routes feat: reduce the chance of regenerating conventional routes Mar 7, 2021
@sorrycc sorrycc merged commit d17ceca into master Mar 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/conventional-routes-regenerate-cache branch March 7, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] route bug
1 participant