Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Yomitan or 10ten into video player #13

Open
ganqqwerty opened this issue Feb 4, 2025 · 4 comments
Open

Integrate Yomitan or 10ten into video player #13

ganqqwerty opened this issue Feb 4, 2025 · 4 comments
Labels
enhancement New feature or request P1 will work with high priority

Comments

@ganqqwerty
Copy link

Right now LLPlayer is using its own popup-dictionary. It would be great if it could support Yomitan, that is a default tool for Japanese, has hundreds of dictionaries and very lively community: https://github.com/yomidevs/yomitan .

@umlx5h
Copy link
Owner

umlx5h commented Feb 4, 2025

In the future I plan to support yomitan or 10ten or whatever, but first I would like to support Japanese word segmentation using NmeCab.

I’m considering two methods of integrating browser extensions.

One is to display a transparent WebView with an overlay element, like a subtitle, so that specific browser extensions can be integrated (only specific extensions).
This has not yet been tested and it is not clear if it is feasible.

The second is to set up a web server so that you can view a current subtitle or list of subtitles via a browser.
This is probably feasible and can use any browser extension, but may be a little less convenient since it is treated as a separate window.

Please comment if you have ideas, including others, PR is welcome.

@umlx5h umlx5h added the enhancement New feature or request label Feb 4, 2025
@ganqqwerty
Copy link
Author

Is it possible that Matt that made Yomininja used this approach? His OCR program creates an overlay and supports yomitan and 10ten. Maybe his code can serve as inspiration? https://github.com/matt-m-o/YomiNinja

@umlx5h umlx5h added the P2 will work with medium priority label Feb 10, 2025
@umlx5h
Copy link
Owner

umlx5h commented Feb 10, 2025

I have found that it is possible to integrate with browser extensions such as Yomitan just by introducing automatic clipboard copying.
It will be an external window, but it can be linked to any extension. It may also work with Anki if you use other browser extensions.

reference
https://animecards.site/minefromanime/#requirements

First implement this feature right away, and then will consider incorporating browser extensions into the video player. (one method above)

@umlx5h umlx5h changed the title Yomitan support Integrate Yomitan or 10ten into video player Feb 12, 2025
@umlx5h
Copy link
Owner

umlx5h commented Feb 12, 2025

I have added the ability to integrate with the browser extensions via clipboard in v0.1.0.
It will be an external browser window, but it can be linked with Yomitan or 10ten.

Please refer to the following page for details.
https://github.com/umlx5h/LLPlayer/wiki/Browser-Extensions-Integration

I will continue to consider incorporating it into the video player.

@umlx5h umlx5h added P1 will work with high priority and removed P2 will work with medium priority labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 will work with high priority
Projects
None yet
Development

No branches or pull requests

2 participants