Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rule type of rate_limit_statement doesn't support forward_ip_config #68

Closed
wesleykirkland opened this issue Nov 1, 2022 · 1 comment

Comments

@wesleykirkland
Copy link
Contributor

What is the current behavior?
rate_limit_statement doesn't have the ability to input rate_limit_statement as a statement inside of it.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
The following is custom input to the module though validated.

The supported logic can be seen here - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/wafv2_rule_group#ip-set-reference-statement

name     = "test"
        priority = "30"

        action = "block"

        visibility_config = {
          cloudwatch_metrics_enabled = false
          metric_name                = "test"
          sampled_requests_enabled   = true
        }


        rate_based_statement = {
          limit              = 375
          aggregate_key_type = "FORWARDED_IP"
          forwarded_ip_config = {
            fallback_behavior = "NO_MATCH"
            header_name       = "X-Forwarded-For"
          }
        }

You can see here that the logic is using rule.value instead of rate_based_statement.value

What is the expected behavior?
forwarded_ip_config should be passed down.

Software versions?
3.8.1

@Ohid25
Copy link
Contributor

Ohid25 commented Jan 26, 2023

Part of the 4.0.0 release! Thank you for your contribution!

@Ohid25 Ohid25 closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants