fix: some known issues and code review

Author: JounQin

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
             node: lts/*
             eslint: 9
             os: ubuntu-latest
-          - noLegacyNodeResolver: true
+          - legacyNodeResolver: true
             node: lts/*
             eslint: 9
             os: ubuntu-latest
@@ -58,8 +58,8 @@ jobs:
         run: yarn --immutable
 
       - name: Uninstall Legacy Node Resolver
-        if: ${{ matrix.noLegacyNodeResolver }}
-        run: yarn remove eslint-import-resolver-node
+        if: ${{ matrix.legacyNodeResolver }}
+        run: yarn add -D eslint-import-resolver-node
 
       - name: Build and Test
         run: yarn run-s test-compiled test

package.json

@@ -128,7 +128,6 @@
     "eslint": "^9.27.0",
     "eslint-config-prettier": "^10.1.5",
     "eslint-doc-generator": "^2.1.2",
-    "eslint-import-resolver-node": "^0.3.9",
     "eslint-import-resolver-typescript": "^4.4.1",
     "eslint-import-resolver-webpack": "^0.13.10",
     "eslint-import-test-order-redirect": "link:./test/fixtures/order-redirect",

src/rules/no-named-as-default.ts

@@ -40,6 +40,7 @@ export default createRule<[], MessageId>({
           declaration.source.value,
           context,
         )
+
         if (exportMapOfImported == null) {
           return
         }

src/utils/legacy-resolver-settings.ts

@@ -96,17 +96,16 @@ export function normalizeConfigResolvers(
   return [...map.values()]
 }
 
-export const LEGACY_NODE_RESOLVERS = [
+export const LEGACY_NODE_RESOLVERS = new Set([
   'node',
   'eslint-import-resolver-node',
-  (function () {
-    try {
-      return cjsRequire.resolve('eslint-import-resolver-node')
-    } catch {
-      // ignore
-    }
-  })(),
-].filter(Boolean)
+])
+
+try {
+  LEGACY_NODE_RESOLVERS.add(cjsRequire.resolve('eslint-import-resolver-node'))
+} catch {
+  // ignore
+}
 
 function requireResolver(name: string, sourceFile: string) {
   // Try to resolve package with conventional name
@@ -117,7 +116,7 @@ function requireResolver(name: string, sourceFile: string) {
 
   if (!resolver) {
     // ignore `node` resolver not found error, we'll use the new one instead
-    if (LEGACY_NODE_RESOLVERS.includes(name)) {
+    if (LEGACY_NODE_RESOLVERS.has(name)) {
       return undefined!
     }
 

src/utils/resolve.ts

@@ -130,7 +130,7 @@ function legacyNodeResolve(
     includeCoreModules,
     moduleDirectory,
     paths,
-    preserveSymlinks: symlinks,
+    preserveSymlinks,
     package: packageJson,
     packageFilter,
     pathFilter,
@@ -142,6 +142,9 @@ function legacyNodeResolve(
 
   const modules = arraify(moduleDirectory)
 
+  // TODO: change the default behavior to align node itself
+  const symlinks = preserveSymlinks === false
+
   const resolver = createNodeResolver({
     extensions: normalizedExtensions,
     builtinModules: includeCoreModules !== false,
@@ -299,7 +302,7 @@ function fullResolve(
       }
 
       // if the resolver is `eslint-import-resolver-node`, we use the new `node` resolver as fallback instead
-      if (LEGACY_NODE_RESOLVERS.includes(name) && !resolver) {
+      if (LEGACY_NODE_RESOLVERS.has(name)) {
         const resolverOptions = (options || {}) as NodeResolverOptions
         const resolved = legacyNodeResolve(
           {
@@ -317,7 +320,9 @@ function fullResolve(
           return resolved
         }
 
-        continue
+        if (!resolver) {
+          continue
+        }
       }
 
       const resolved = setRuleContext(context, () =>

yarn.lock

@@ -5784,17 +5784,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"eslint-import-resolver-node@npm:^0.3.9":
-  version: 0.3.9
-  resolution: "eslint-import-resolver-node@npm:0.3.9"
-  dependencies:
-    debug: "npm:^3.2.7"
-    is-core-module: "npm:^2.13.0"
-    resolve: "npm:^1.22.4"
-  checksum: 10c0/0ea8a24a72328a51fd95aa8f660dcca74c1429806737cf10261ab90cfcaaf62fd1eff664b76a44270868e0a932711a81b250053942595bcd00a93b1c1575dd61
-  languageName: node
-  linkType: hard
-
 "eslint-import-resolver-typescript@npm:^4.4.1":
   version: 4.4.1
   resolution: "eslint-import-resolver-typescript@npm:4.4.1"
@@ -5956,7 +5945,6 @@ __metadata:
     eslint-config-prettier: "npm:^10.1.5"
     eslint-doc-generator: "npm:^2.1.2"
     eslint-import-context: "npm:^0.1.6"
-    eslint-import-resolver-node: "npm:^0.3.9"
     eslint-import-resolver-typescript: "npm:^4.4.1"
     eslint-import-resolver-webpack: "npm:^0.13.10"
     eslint-import-test-order-redirect: "link:./test/fixtures/order-redirect"
@@ -11585,7 +11573,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"resolve@npm:^1.14.2, resolve@npm:^1.20.0, resolve@npm:^1.22.4":
+"resolve@npm:^1.14.2, resolve@npm:^1.20.0":
   version: 1.22.10
   resolution: "resolve@npm:1.22.10"
   dependencies:
@@ -11611,7 +11599,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"resolve@patch:resolve@npm%3A^1.14.2#optional!builtin<compat/resolve>, resolve@patch:resolve@npm%3A^1.20.0#optional!builtin<compat/resolve>, resolve@patch:resolve@npm%3A^1.22.4#optional!builtin<compat/resolve>":
+"resolve@patch:resolve@npm%3A^1.14.2#optional!builtin<compat/resolve>, resolve@patch:resolve@npm%3A^1.20.0#optional!builtin<compat/resolve>":
   version: 1.22.10
   resolution: "resolve@patch:resolve@npm%3A1.22.10#optional!builtin<compat/resolve>::version=1.22.10&hash=c3c19d"
   dependencies: