-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update checks write permisions on release workflow #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportCaution Coverage does not meet threshold
Test suite run success0 tests passing in 0 suite. Report generated by π§ͺjest coverage report action from 567d45f |
huynguyen-hl
previously approved these changes
Jan 17, 2025
huynguyen-hl
approved these changes
Jan 17, 2025
namhoang1604
approved these changes
Jan 17, 2025
huynguyen-hl
pushed a commit
that referenced
this pull request
Jan 17, 2025
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure you've done the following: - π Read the [Contributing Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md). - π Read the [Code of Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md). - π·ββοΈ Create small PRs. In most cases, this will be possible. - β Provide tests for your changes. - π Use descriptive commit messages following [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/). - π Update any related documentation and include any relevant screenshots. --> ## What type of PR is this? (check all applicable) - [ ] π Feature - [ ] π Bug Fix - [ ] π Documentation Update - [ ] π¨ Style - [ ] π§βπ» Code Refactor - [ ] π₯ Performance Improvements - [ ] β Test - [ ] π€ Build - [ ] π CI - [x] π¦ Chore (Release) - [ ] β© Revert ## Description <!-- Please do not leave this blank This PR [adds/removes/fixes/replaces] the [feature/bug/etc]. --> ## Related Tickets & Documents <!-- Please use this format link issue numbers: Fixes #123 https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Mobile & Desktop Screenshots/Recordings <!-- Visual changes require screenshots --> ## Added tests? - [ ] π yes - [x] π no, because they aren't needed - [ ] π no, because I need help ## Added to documentation? - [ ] π README.md - [ ] π [vc-kit doc site](https://uncefact.github.io/vckit/) - [ ] π storybook - [x] π no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- note: PRs with deleted sections will be marked invalid -->
ldhyen99
added a commit
that referenced
this pull request
Jan 17, 2025
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure you've done the following: - π Read the [Contributing Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md). - π Read the [Code of Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md). - π·ββοΈ Create small PRs. In most cases, this will be possible. - β Provide tests for your changes. - π Use descriptive commit messages following [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/). - π Update any related documentation and include any relevant screenshots. --> ## What type of PR is this? (check all applicable) - [ ] π Feature - [ ] π Bug Fix - [ ] π Documentation Update - [ ] π¨ Style - [ ] π§βπ» Code Refactor - [ ] π₯ Performance Improvements - [ ] β Test - [ ] π€ Build - [ ] π CI - [x] π¦ Chore (Release) - [ ] β© Revert ## Description <!-- Please do not leave this blank This PR [adds/removes/fixes/replaces] the [feature/bug/etc]. --> ## Related Tickets & Documents <!-- Please use this format link issue numbers: Fixes #123 https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Mobile & Desktop Screenshots/Recordings <!-- Visual changes require screenshots --> ## Added tests? - [ ] π yes - [x] π no, because they aren't needed - [ ] π no, because I need help ## Added to documentation? - [ ] π README.md - [ ] π [vc-kit doc site](https://uncefact.github.io/vckit/) - [ ] π storybook - [x] π no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- note: PRs with deleted sections will be marked invalid -->
huynguyen-hl
pushed a commit
that referenced
this pull request
Jan 17, 2025
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure you've done the following: - π Read the [Contributing Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md). - π Read the [Code of Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md). - π·ββοΈ Create small PRs. In most cases, this will be possible. - β Provide tests for your changes. - π Use descriptive commit messages following [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/). - π Update any related documentation and include any relevant screenshots. --> ## What type of PR is this? (check all applicable) - [ ] π Feature - [ ] π Bug Fix - [ ] π Documentation Update - [ ] π¨ Style - [ ] π§βπ» Code Refactor - [ ] π₯ Performance Improvements - [ ] β Test - [ ] π€ Build - [ ] π CI - [x] π¦ Chore (Release) - [ ] β© Revert ## Description <!-- Please do not leave this blank This PR [adds/removes/fixes/replaces] the [feature/bug/etc]. --> ## Related Tickets & Documents <!-- Please use this format link issue numbers: Fixes #123 https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Mobile & Desktop Screenshots/Recordings <!-- Visual changes require screenshots --> ## Added tests? - [ ] π yes - [x] π no, because they aren't needed - [ ] π no, because I need help ## Added to documentation? - [ ] π README.md - [ ] π [vc-kit doc site](https://uncefact.github.io/vckit/) - [ ] π storybook - [x] π no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- note: PRs with deleted sections will be marked invalid -->
ldhyen99
added a commit
that referenced
this pull request
Jan 17, 2025
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure you've done the following: - π Read the [Contributing Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md). - π Read the [Code of Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md). - π·ββοΈ Create small PRs. In most cases, this will be possible. - β Provide tests for your changes. - π Use descriptive commit messages following [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/). - π Update any related documentation and include any relevant screenshots. --> ## What type of PR is this? (check all applicable) - [ ] π Feature - [ ] π Bug Fix - [ ] π Documentation Update - [ ] π¨ Style - [ ] π§βπ» Code Refactor - [ ] π₯ Performance Improvements - [ ] β Test - [ ] π€ Build - [ ] π CI - [x] π¦ Chore (Release) - [ ] β© Revert ## Description <!-- Please do not leave this blank This PR [adds/removes/fixes/replaces] the [feature/bug/etc]. --> ## Related Tickets & Documents <!-- Please use this format link issue numbers: Fixes #123 https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## Mobile & Desktop Screenshots/Recordings <!-- Visual changes require screenshots --> ## Added tests? - [ ] π yes - [x] π no, because they aren't needed - [ ] π no, because I need help ## Added to documentation? - [ ] π README.md - [ ] π [vc-kit doc site](https://uncefact.github.io/vckit/) - [ ] π storybook - [x] π no documentation needed ## [optional] Are there any post-deployment tasks we need to perform? <!-- note: PRs with deleted sections will be marked invalid -->
This was referenced Jan 17, 2025
huynguyen-hl
added a commit
that referenced
this pull request
Jan 17, 2025
π€: I have generated a release changelog --- ## [1.0.2](1.0.1...v1.0.2) (2025-01-17) ### Miscellaneous * Update checks write permisions on release workflow ([#246](#246)) ([be1e8bc](be1e8bc)) * Update version 1.0.2 ([3024669](3024669)) --- This PR was automatically generated by π€. --------- Co-authored-by: Huy Nguyen <huy.nguyenkim.h@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?