Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier on the webhook deploy - or remove it entirely #169

Open
nissimsan opened this issue Sep 13, 2024 · 2 comments
Open

Run prettier on the webhook deploy - or remove it entirely #169

nissimsan opened this issue Sep 13, 2024 · 2 comments
Assignees

Comments

@nissimsan
Copy link
Contributor

When I raise fixes on JSON files, github runs prettier on my file, making it impossible to see the delicate changes I actually have made. Example: #168

I could .prettierignore my way around this, but that isn't fixing the root problem.

Options:

  • Ensure that the webhook deploy of JSONs are subjected to prettier so ALL files are formatted according to the convention
  • Reconfigure prettier (and make it catch erronous , in JSON files now we're at it)
  • Remove prettier altogether
  • Patch-hack file by file (bad)
  • Accept as is where any manual corrections result in huge, impossible to read PRs (bad)
@nissimsan
Copy link
Contributor Author

Even worse example: here prettier breaks the formatting. Very disruptive.

@onthebreeze
Copy link
Contributor

onthebreeze commented Nov 14, 2024

Strange but I cant repeat this issue with my setup. macBook pro, Github Desktop client, Sublime Text editor. When I make a commit, there is no prettier reformatting happening on GitHub side.

Has anyone else seen this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants