Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 FAILS reported on Roman VF #224

Open
vv-monsalve opened this issue Aug 18, 2020 · 3 comments
Open

🔥 FAILS reported on Roman VF #224

vv-monsalve opened this issue Aug 18, 2020 · 3 comments
Assignees
Milestone

Comments

@vv-monsalve
Copy link
Contributor

The main Fails reported on the Roman VF Fraunces[SOFT,WONK,opsz,wght].ttf are on the Typographic Subfamily Name for Windows (Name ID 17) and Instance Names. The latter must be related to what is required according to the Spec about Instances.

Note: Despite the Italic font couldn't be produced for an Error when running the build.sh, this same Fails would be expected for that font too.

🔥 FAIL: Check name table: TYPOGRAPHIC_SUBFAMILY_NAME entries.
🔥 FAIL: Check variable font instances have correct names
  • com.google.fonts/check/varfont_instance_names

  • 🔥 FAIL Following instances are not supported:

    • 9pt S000 Thin
    • 9pt S000 Light
    • 9pt S000 Regular
    • 9pt S000 SemiBold
    • 9pt S000 Bold
    • 9pt S000 Black
    • 9pt S050 Thin
    • 9pt S050 Light
    • 9pt S050 Regular
    • 9pt S050 SemiBold
    • 9pt S050 Bold
    • 9pt S050 Black
    • 9pt S100 Thin
    • 9pt S100 Light
    • 9pt S100 Regular
    • 9pt S100 SemiBold
    • 9pt S100 Bold
    • 9pt S100 Black
    • 72pt S000 Thin
    • 72pt S000 Light
    • 72pt S000 Regular
    • 72pt S000 SemiBold
    • 72pt S000 Bold
    • 72pt S000 Black
    • 72pt S050 Thin
    • 72pt S050 Light
    • 72pt S050 Regular
    • 72pt S050 SemiBold
    • 72pt S050 Bold
    • 72pt S050 Black
    • 72pt S100 Thin
    • 72pt S100 Light
    • 72pt S100 Regular
    • 72pt S100 SemiBold
    • 72pt S100 Bold
    • 72pt S100 Black
    • 144pt S000 Thin
    • 144pt S000 Light
    • 144pt S000 Regular
    • 144pt S000 SemiBold
    • 144pt S000 Bold
    • 144pt S000 Black
    • 144pt S050 Thin
    • 144pt S050 Light
    • 144pt S050 Regular
    • 144pt S050 SemiBold
    • 144pt S050 Bold
    • 144pt S050 Black

Further info can be found in our spec https://github.com/googlefonts/gf-docs/tree/master/Spec#fvar-instances [code: bad-instance-names]

@sponcey
Copy link
Collaborator

sponcey commented Aug 19, 2020

In issue #209, @davelab6 said that this first fail can be ignored.

The second fail, I'm not sure about that one. Perhaps @davelab6 can clarify: Is this spec going to be updated, since Fraunces needs to have instance names that reflect its multiple axes?

@sponcey sponcey added this to the Fraunces v1.0 milestone Aug 20, 2020
@davelab6
Copy link
Contributor

@m4rc1e can better answer this.

@davelab6
Copy link
Contributor

davelab6 commented Sep 8, 2020

Re-reading this, the GF Spec policy at the moment is to limit the fvar instances to the "Weight Width Slope" model from Windows Vista+. The other styles should be named in the STAT table. @vv-monsalve can handle this

@sponcey sponcey assigned sponcey and vv-monsalve and unassigned sponcey Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants