Skip to content
This repository has been archived by the owner on Feb 17, 2023. It is now read-only.

Feat/source maps #84

Merged
merged 8 commits into from
May 29, 2021
Merged

Feat/source maps #84

merged 8 commits into from
May 29, 2021

Conversation

qnp
Copy link
Contributor

@qnp qnp commented May 27, 2021

Hello,

I have an attempt here to add full source-maps support for this plugin:

  • emit source map for templates (inspired by vue 3)
  • emit source map for styles
  • use empty source map to avoid rollup complaining

Tell me if you think it is correct,

I'm not sure how to debug the built sourcemaps..

Best,

@underfin underfin force-pushed the feat/source-maps branch from ccf4bec to d946cd6 Compare May 29, 2021 09:43
@underfin underfin merged commit 97f2ca4 into underfin:master May 29, 2021
@underfin
Copy link
Owner

underfin commented May 29, 2021

Thanks for your work, but add template block sourmap will conflict with script block sourcemap at hmr, so i revert it. Just use map: null also let rollup happy.

@qnp
Copy link
Contributor Author

qnp commented May 31, 2021

Perfect, thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants