Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking reports can act as clicking the carosel buttons #1565

Open
infosec-alchemist opened this issue Nov 8, 2018 · 4 comments
Open

clicking reports can act as clicking the carosel buttons #1565

infosec-alchemist opened this issue Nov 8, 2018 · 4 comments
Labels
Milestone

Comments

@infosec-alchemist
Copy link
Contributor

When I open a threat board, and I select the left hand "reports" button to show my reports list.

image

Then, I start paging through available reports by clicking one of the dots
image

After clicking one of the dots, I then start selecting reports on the left hand side, the available reports starts cycling through like I'm advancing through them with the arrows or the dots

@ghost
Copy link

ghost commented Nov 8, 2018

Wow, this is a fun one. What's happening is that those reports are apparently linking back to the feed page. Angular takes that as a route request to the current page. This is not a browser page load, it's a call to Angular to render the requested page. A page that is already rendered, but eh who cares?, Angular does it anyway. So it's not scrolling, it's just redrawing everything, including the carousel, which appears to get reset back to its first report.

I don't know what the action is supposed to be when clicking on a report, if anything; but I'm thinking it was probably just made into a link to have something to do for now.

@mpmmasterpeace
Copy link
Contributor

When you click on a report in article view, it loads that report into the center pane.

Perhaps we need some logic in that shared component to know which of the three views it's in and do something appropriate.

@infosec-alchemist
Copy link
Contributor Author

Clicking the left hand report does not load the report into the center pane. If I have not touched the carousel buttons (open the board for the first time), clicking the reports does not change the carousel location.

If I follow the instructions above, they cycle through, but never showing the correct report

@mpmmasterpeace
Copy link
Contributor

@infosec-alchemist I was speaking of the article tab view of a threat board.

That is where clicking on the report in the left pane will load the report into the center pane.
In the Feed or Board views, it should not do anything currently. Certainly not what you're experiencing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants