Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Uploading a PNG with transparency results in an icon with black background #427

Open
1 task done
uvjim opened this issue Jan 2, 2025 · 3 comments
Open
1 task done
Labels
bug Something isn't working web configurator Web configurator related issue

Comments

@uvjim
Copy link

uvjim commented Jan 2, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Description

When uploading icons using beta 2.2.2 the icon is uploaded, but the transparent background becomes black. This is then shown thought the UI (including on the remote) with clipping and a black background.

I did not have this issue when uploading using non-beta firmware. I've tested on multiple browsers and multiple OS platforms. Have also tested by downloading an existing icon from the remote (uploaded using a non-beta firmware) and attempting to upload again.

How to Reproduce

  1. Upload a custom icon with a transparent background.

Tests were carried out using the "Advanced Export" feature found at: https://pictogrammers.com/library/mdi/. I used this on previous firmware versions without issue. I set the size to 90px and the padding to 2.

Expected behavior

The background of the icon stays transparent as per the original behaviour of non-beta firmware.

System version

2.2.2

What part of the system affected by the problem?

Web Configurator

Additional context

This image should show the black background where it should be transparent.

Image

@kennymc-c
Copy link

I can confirm this. I also noticed that uploading the exact same image results in a softer, slightly scaled up version than with the old configurator:
Image

@zehnm
Copy link

zehnm commented Jan 6, 2025

Confirmed: this is a known issue in our backlog. Correctly sized icons may not be modified by the web-configurator, and directly uploaded (as with the Core-API).
Resizing is only for non-fitting icon sizes.

@uvjim
Copy link
Author

uvjim commented Jan 6, 2025

@zehnm Thanks for the tip. I can confirm using the Core-API the icons upload correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web configurator Web configurator related issue
Projects
Status: Reported
Development

No branches or pull requests

3 participants