Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warnings about rank of design matrix #130

Open
olafdimigen opened this issue May 3, 2022 · 0 comments
Open

Incorrect warnings about rank of design matrix #130

olafdimigen opened this issue May 3, 2022 · 0 comments

Comments

@olafdimigen
Copy link
Member

olafdimigen commented May 3, 2022

as part of creating the design matrix with uf_designmat, unfold checks the rank of the design matrix and gives out a warning if the rank is smaller than the number of columns of the DM.
check_rank(EEG.unfold.X)

However, this seems to happen even with uncorrelated predictors. The reason appears to be that when creating the (original, non-time-expanded) DM, all EEG.event entries in the original EEG dataset are represented as one row in the DM, regardless of whether the event type is part of the model formula or not. These zero-only rows then appear to affect the rank computation.

Possible fixes:

  • ? remove zero-only rows from non-modelled event types from DM (may cause downstream problems...)
  • ? exclude zero-only rows from rank check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant