Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'hyphens' CSS property isn't working #3135

Open
1 of 3 tasks
pnwheeler opened this issue Dec 28, 2024 · 7 comments
Open
1 of 3 tasks

'hyphens' CSS property isn't working #3135

pnwheeler opened this issue Dec 28, 2024 · 7 comments
Labels

Comments

@pnwheeler
Copy link

pnwheeler commented Dec 28, 2024

OS/Platform

Windows

Installed

https://ungoogled-software.github.io/ungoogled-chromium-binaries/

Version

Version 131.0.6778.204 (Official Build, ungoogled-chromium) (64-bit)

Have you tested that this is not an upstream issue or an issue with your configuration?

  • I have tried reproducing this issue in Chrome and it could not be reproduced there
  • I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
  • I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description

Hyphenation rules aren't being rendered

How to Reproduce?

  1. Apply hyphenation in CSS (e.g. hyphens:auto, or check out a test page).
  2. (Observe no changes)

Actual behaviour

The property has no effect on the rendered text. In ungoogled chromium:
image

Expected behaviour

Hyphen rules should be applied. In fresh/latest Chrome install (131.0.6778.205) :
image

Relevant log output

No response

Additional context

I haven't gone through toggling each flag yet, but here's the command I have under chrome://settings:
"\chrome.exe" --restart --restart --flag-switches-begin --disable-search-engine-collection --disable-sharing-hub --enable-experimental-web-platform-features --enable-gpu-rasterization --extension-mime-request-handling=always-prompt-for-install --force-dark-mode --scroll-tabs=always --enable-features=FluentOverlayScrollbar,OverlayScrollbar,TabGroupsSaveUIUpdate,WebRtcHideLocalIpsWithMdns,WindowsScrollingPersonality --disable-features=ChromeLabs,GlobalMediaControlsCastStartStop --flag-switches-end

I'm almost certain hyphenation was working at some point in the past year--assuming my settings aren't the culprit, I think the issue would be somewhere in the blink>renderer>core>layout>inline code

@pnwheeler pnwheeler added the bug label Dec 28, 2024
@networkException
Copy link
Member

networkException commented Dec 28, 2024

It looks like the data for this is downloaded at runtime (see chrome://components), which ungoogled blocks of course.

@ungoogled-software/core is this something we want to ship by default? I assume the implementation will be platform dependent though (see https://chromium.googlesource.com/chromium/src/+/HEAD/components/component_updater/README.md perhaps)

@PF4Public
Copy link
Contributor

One could manually copy hyphenation data either from another browser or from AOSP source tree once per profile. See #188 (comment)

@pnwheeler
Copy link
Author

Ah, thank you! I copied the folder over from Edge and it works perfectly

@Ahrotahn
Copy link
Contributor

The interesting thing is that the hyphenation data is already included in the tarballs and our source clones. I'm not sure why they don't just bundle that by default. They do that for testing builds since the updater can be disabled.

I've just tested a patch to bundle the data, so if that's something y'all would like to include I could make a PR with the changes. The only catch is that each of the platforms would need to be updated to include that directory in their package to work by default.

@PF4Public
Copy link
Contributor

PF4Public commented Dec 29, 2024

I've just tested a patch to bundle the data, […] would need to be updated to include that directory in their package to work by default.

Do you imply that it is possible to bundle this directory with the binary and it would work without modifying the profile? Or merely making a symlink would suffice?

@Ahrotahn
Copy link
Contributor

Do you imply that it is possible to bundle this directory with the binary and it would work without modifying the profile?

Yes!

Or merely making a symlink would suffice?

That would also work!

It first checks for the directory alongside the binary then inside the profile if that doesn't exist.

@PF4Public
Copy link
Contributor

It first checks for the directory alongside the binary then inside the profile if that doesn't exist.

That would be an easy fix then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants