-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'hyphens' CSS property isn't working #3135
Comments
It looks like the data for this is downloaded at runtime (see chrome://components), which ungoogled blocks of course. @ungoogled-software/core is this something we want to ship by default? I assume the implementation will be platform dependent though (see https://chromium.googlesource.com/chromium/src/+/HEAD/components/component_updater/README.md perhaps) |
One could manually copy hyphenation data either from another browser or from AOSP source tree once per profile. See #188 (comment) |
Ah, thank you! I copied the folder over from Edge and it works perfectly |
The interesting thing is that the hyphenation data is already included in the tarballs and our source clones. I'm not sure why they don't just bundle that by default. They do that for testing builds since the updater can be disabled. I've just tested a patch to bundle the data, so if that's something y'all would like to include I could make a PR with the changes. The only catch is that each of the platforms would need to be updated to include that directory in their package to work by default. |
Do you imply that it is possible to bundle this directory with the binary and it would work without modifying the profile? Or merely making a symlink would suffice? |
Yes!
That would also work! It first checks for the directory alongside the binary then inside the profile if that doesn't exist. |
That would be an easy fix then! |
OS/Platform
Windows
Installed
https://ungoogled-software.github.io/ungoogled-chromium-binaries/
Version
Version 131.0.6778.204 (Official Build, ungoogled-chromium) (64-bit)
Have you tested that this is not an upstream issue or an issue with your configuration?
--user-data-dir
command line argument and it could not be reproduced thereDescription
Hyphenation rules aren't being rendered
How to Reproduce?
Actual behaviour
The property has no effect on the rendered text. In ungoogled chromium:
![image](https://private-user-images.githubusercontent.com/31429354/399101960-dfd2d11b-f9c6-452a-ad7a-f49e43b5dac1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0Mjk1MjYsIm5iZiI6MTczOTQyOTIyNiwicGF0aCI6Ii8zMTQyOTM1NC8zOTkxMDE5NjAtZGZkMmQxMWItZjljNi00NTJhLWFkN2EtZjQ5ZTQzYjVkYWMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDA2NDcwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE3MTBkMjIzMDgyMDE4ODFmNjhhNzhmNGNmYzUxMmE5MDdkOGUzMTJlMmE5ZGNlOTBhZjNkYjY5YjE1MDMxOGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.rtXjWy5P4yVjC0FSNKF1FVg_jqx7DzccZxRhSY7hopk)
Expected behaviour
Hyphen rules should be applied. In fresh/latest Chrome install (131.0.6778.205) :
![image](https://private-user-images.githubusercontent.com/31429354/399102049-45b402a8-44a7-42f4-bc51-19764a549dc2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0Mjk1MjYsIm5iZiI6MTczOTQyOTIyNiwicGF0aCI6Ii8zMTQyOTM1NC8zOTkxMDIwNDktNDViNDAyYTgtNDRhNy00MmY0LWJjNTEtMTk3NjRhNTQ5ZGMyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDA2NDcwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYwMmU2NDBlNDNlZTIwNmQ0YmZiNjIxYWQ4OGZkMWZhNGRlN2M5OTdlZGRiMTEyNzMzYTFhNDk5OGU0NDdmMTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dnbPjIXH15pdhEzdlWJs6tnYU_85s55t1dUAz0oH0fc)
Relevant log output
No response
Additional context
I haven't gone through toggling each flag yet, but here's the command I have under chrome://settings:
"\chrome.exe" --restart --restart --flag-switches-begin --disable-search-engine-collection --disable-sharing-hub --enable-experimental-web-platform-features --enable-gpu-rasterization --extension-mime-request-handling=always-prompt-for-install --force-dark-mode --scroll-tabs=always --enable-features=FluentOverlayScrollbar,OverlayScrollbar,TabGroupsSaveUIUpdate,WebRtcHideLocalIpsWithMdns,WindowsScrollingPersonality --disable-features=ChromeLabs,GlobalMediaControlsCastStartStop --flag-switches-end
I'm almost certain hyphenation was working at some point in the past year--assuming my settings aren't the culprit, I think the issue would be somewhere in the blink>renderer>core>layout>inline codeThe text was updated successfully, but these errors were encountered: