Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding search interface to Char16Trie #1445

Open
dminor opened this issue Dec 23, 2021 · 2 comments
Open

Consider adding search interface to Char16Trie #1445

dminor opened this issue Dec 23, 2021 · 2 comments
Labels
C-unicode Component: Props, sets, tries good first issue Good for newcomers help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-enhancement Type: Nice-to-have but not required
Milestone
Backlog ⟨P4⟩

Comments

@dminor
Copy link
Contributor

dminor commented Dec 23, 2021

Rather than using an iterator, we could search on the Char16Trie itself, like Shane suggested in #1264 (comment).
@dminor dminor mentioned this issue Dec 23, 2021
Merged
@sffc sffc added backlog C-unicode Component: Props, sets, tries good first issue Good for newcomers help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-enhancement Type: Nice-to-have but not required labels Dec 23, 2021
@sffc
Copy link
Member

sffc commented Apr 13, 2022

@palashahuja may be interested in this.

@Manishearth
Copy link
Member

icu4x/experimental/char16trie/src/char16trie.rs

Line 81 in 7d75be3

pub struct Char16Trie<'data> {

@sffc sffc mentioned this issue May 27, 2022
Closed
@sffc sffc added this to the Backlog milestone Dec 22, 2022
@sffc sffc removed the backlog label Dec 22, 2022
@sffc sffc mentioned this issue Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-unicode Component: Props, sets, tries good first issue Good for newcomers help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-enhancement Type: Nice-to-have but not required
Projects
None yet
Milestone
Backlog ⟨P4⟩
Development

No branches or pull requests
3 participants
@dminor @sffc @Manishearth