Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tooling to keep track of (and enforce) that our data structs do not allocate #1661

Closed
Manishearth opened this issue Mar 3, 2022 · 2 comments · Fixed by #1670
Closed

Write tooling to keep track of (and enforce) that our data structs do not allocate #1661

Manishearth opened this issue Mar 3, 2022 · 2 comments · Fixed by #1670
Assignees
@Manishearth
Labels
A-data Area: Data coverage or quality C-data-infra Component: provider, datagen, fallback, adapters
Milestone
2022 Q1 0.6 Sprint D

Comments

@Manishearth
Copy link
Member

Manishearth commented Mar 3, 2022 •
edited by sffc
Loading

Fixes #856

We should keep track of which keys are not zero-copy yet, via a test that uses assert_no_alloc or dhat, and store the list in a sorted golden file so that any changes get tracked.

cc @sffc @robertbastian
@Manishearth Manishearth added C-data-infra Component: provider, datagen, fallback, adapters A-data Area: Data coverage or quality labels Mar 3, 2022
@Manishearth Manishearth added this to the 2022 Q1 0.6 Sprint D milestone Mar 3, 2022
@Manishearth Manishearth self-assigned this Mar 3, 2022
This was referenced Mar 3, 2022
Closed
Closed
@Manishearth
Copy link
Member Author

Blocked on #1512

@Manishearth Manishearth mentioned this issue Mar 5, 2022
Merged
2 tasks
@Manishearth
Copy link
Member Author

PR: #1670

@robertbastian robertbastian mentioned this issue Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-data Area: Data coverage or quality C-data-infra Component: provider, datagen, fallback, adapters
Projects
None yet
Milestone
2022 Q1 0.6 Sprint D
Development

Successfully merging a pull request may close this issue.

Add payload conversion and heap measurement tool Manishearth/icu4x
1 participant
@Manishearth