Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add continuous integration for non-testdata data generation #1698

Closed
robertbastian opened this issue Mar 15, 2022 · 7 comments · Fixed by #2021
Closed

Add continuous integration for non-testdata data generation #1698

robertbastian opened this issue Mar 15, 2022 · 7 comments · Fixed by #2021
Assignees
@robertbastian
Labels
C-test-infra Component: Integration test infrastructure S-small Size: One afternoon (small bug fix or enhancement) T-docs-tests Type: Code change outside core library
Milestone
ICU4X 1.0 (Polish)

Comments

@robertbastian
Copy link
Member

#1353 added scx.toml to testdata, but it's not in the current icuexportdata_uprops_full.zip, so data generation with --all-keys has been broken since then, including at the 0.5 cut.
@ptmphuong ptmphuong mentioned this issue Mar 23, 2022
Closed
@sapriyag
Copy link
Contributor

Robert can this be closed? Is Shane changes sufficient to close this issues?

@robertbastian
Copy link
Member Author

Which changes? I'm not aware of anything that could've fixed this

@sapriyag
Copy link
Contributor

@Manishearth Can you help elaborate Shane's changes you mentioned would have fixed this issue?

@Manishearth
Copy link
Member

@robertbastian I was under the impression Shane made some changes to ICU that would fix this, but I don't have full background here.

@Manishearth
Copy link
Member

Oh, wait, this issue is for adding CI, never mind.

@sffc
Copy link
Member

sffc commented May 12, 2022

My concern here is that it makes our CI rely on downloading the source data from somewhere, which could be flaky.

@sffc sffc added the discuss Discuss at a future ICU4X-SC meeting label May 12, 2022
@sffc
Copy link
Member

sffc commented May 20, 2022

Conclusion 2022-05-20:

  • Add as a new CI job
  • There should be separate steps for downloading the two ZIP files, which are cached
  • Consider running icu4x-datagen in release mode

LGTM: @sffc, @nordzilla, @dminor, @robertbastian, @Manishearth

@sffc sffc added T-docs-tests Type: Code change outside core library C-test-infra Component: Integration test infrastructure S-small Size: One afternoon (small bug fix or enhancement) and removed discuss Discuss at a future ICU4X-SC meeting labels May 20, 2022
@sffc sffc added this to the ICU4X 1.0 milestone May 20, 2022
@robertbastian robertbastian mentioned this issue Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertbastian robertbastian

Labels
C-test-infra Component: Integration test infrastructure S-small Size: One afternoon (small bug fix or enhancement) T-docs-tests Type: Code change outside core library
Projects
None yet
Milestone
ICU4X 1.0 (Polish)
Development

Successfully merging a pull request may close this issue.

Full datagen CI robertbastian/icu4x
4 participants
@sffc @Manishearth @robertbastian @sapriyag