-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZeroVec Yoke impl started failing "forget-copy" on Nightly #3436
Comments
sffc
added
T-bug
Type: Bad behavior, security, privacy
C-zerovec
Component: Yoke, ZeroVec, DataBake
labels
May 15, 2023
sffc
changed the title
ZeroVec Yoke impl started failing to compile on Nightly
ZeroVec Yoke impl started failing "forget-copy" on Nightly
May 15, 2023
The file already has |
Most likely culprit PR: rust-lang/rust#109732 |
This doesn't break clients. Yes, the lint was uplifted to rustc, and the forget is there in code as more of a visual indicator of end-of-use for the borrow. We should update the allow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The error is:
It seems harmless to fix, but I would really like to stop breaking clients; see #3425
However, it appears to only be a lint, so we might be good if we patch the lint.
CC @Manishearth
The text was updated successfully, but these errors were encountered: