Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into replacing flat DateTimeSymbols arrays with VarZeroVecs #3599

Closed
Tracked by #3413 ...
Manishearth opened this issue Jun 29, 2023 · 2 comments
Closed
Tracked by #3413 ...

Look into replacing flat DateTimeSymbols arrays with VarZeroVecs #3599

Manishearth opened this issue Jun 29, 2023 · 2 comments
Assignees
Labels
C-datetime Component: datetime, calendars, time zones

Comments

@Manishearth
Copy link
Member

Part of #3413

Currently DateTimeSymbols data has a couple of fixed-length arrays. These are big on the stack; it's worth replacing them with VZVs. We'd need to measure if this is actually a major win.

This can be done backwards compatibly but we may wish to consider doing it in 2.0 (#2856).

@sffc
Copy link
Member

sffc commented Oct 5, 2023

Likely to be handled as part of #3865

@sffc sffc self-assigned this Oct 5, 2023
@sffc sffc added this to the 1.4 Blocking ⟨P1⟩ milestone Oct 5, 2023
@sffc sffc added the C-datetime Component: datetime, calendars, time zones label Oct 5, 2023
@sffc sffc closed this as completed May 17, 2024
@sffc sffc assigned Manishearth and unassigned sffc May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-datetime Component: datetime, calendars, time zones
Projects
Status: Done
Development

No branches or pull requests

2 participants