Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI CodePointRangeIterator is missing ICU4X prefix #3851

Closed
Tracked by #2856
sffc opened this issue Aug 11, 2023 · 2 comments
Closed
Tracked by #2856

FFI CodePointRangeIterator is missing ICU4X prefix #3851

sffc opened this issue Aug 11, 2023 · 2 comments
Assignees
@Manishearth
Labels
C-ffi-infra Component: Diplomat, horizontal FFI
Milestone
ICU4X 2.0 ⟨P1⟩

Comments

@sffc
Copy link
Member

sffc commented Aug 11, 2023

No description provided.

@sffc sffc added the C-ffi-infra Component: Diplomat, horizontal FFI label Aug 11, 2023
@sffc sffc added this to the 1.3 Blocking ⟨P1⟩ milestone Aug 11, 2023
@Manishearth Manishearth mentioned this issue Aug 11, 2023
Closed
@sffc sffc modified the milestones: 1.3 Blocking ⟨P1⟩, ICU4X 2.0 Aug 14, 2023
@sffc
Copy link
Member Author

sffc commented Aug 14, 2023

Turns out this is a breaking change; see #3852. Fix in 2.0.

@Manishearth Manishearth mentioned this issue Feb 8, 2024
Open
37 tasks
@Manishearth
Copy link
Member

We don't need this anymore. Everything is deprefixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
C-ffi-infra Component: Diplomat, horizontal FFI
Projects
icu4x 2.0
Status: Done
Milestone
ICU4X 2.0 ⟨P1⟩
Development

Successfully merging a pull request may close this issue.

fix CodePointRangeIterator prefixing Manishearth/icu4x
2 participants
@sffc @Manishearth