Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE file not packaged with individual crates #771

Closed
dminor opened this issue Jun 8, 2021 · 2 comments · Fixed by #790
Closed

LICENSE file not packaged with individual crates #771

dminor opened this issue Jun 8, 2021 · 2 comments · Fixed by #790
Assignees
Labels
C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement) T-task Type: Tracking thread for a non-code task
Milestone

Comments

@dminor
Copy link
Contributor

dminor commented Jun 8, 2021

In our Cargo.toml files we have a license-file with a relative path back to the root LICENSE file. This means that LICENSE is not actually packaged with the individual crates, which breaks tooling that expects to be able read the LICENSE file, like the vendor_rust.py script used to vendor crates into Firefox.

Assuming we can't use license in Cargo.toml to OR together the different licenses we're using, I think that we'll have to include a copy of the LICENSE file with each component that we package as a separate crate.

@dminor dminor added the discuss-priority Discuss at the next ICU4X meeting label Jun 8, 2021
@zbraniecki zbraniecki added this to the ICU4X 0.3 milestone Jun 8, 2021
@sffc
Copy link
Member

sffc commented Jun 10, 2021

2021-06-10:

  • @Manishearth - We should put this as a tidy task like generate-readmes

@sffc sffc added C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement) T-task Type: Tracking thread for a non-code task and removed discuss-priority Discuss at the next ICU4X meeting labels Jun 10, 2021
@dminor
Copy link
Contributor Author

dminor commented Jun 11, 2021

It looks like this is a problem with cargo vendor not with the packaging. I'll leave this open in case there is something we need to do in our Cargo.toml file to make cargo vendor happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement) T-task Type: Tracking thread for a non-code task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants