Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likely subtags minimization of und should be en. #818

Closed
dminor opened this issue Jun 22, 2021 · 3 comments · Fixed by #1170
Closed

Likely subtags minimization of und should be en. #818

dminor opened this issue Jun 22, 2021 · 3 comments · Fixed by #1170
Assignees
Labels
A-scope Area: Project scope, feature coverage C-locale Component: Locale identifiers, BCP47 good first issue Good for newcomers S-small Size: One afternoon (small bug fix or enhancement) T-bug Type: Bad behavior, security, privacy
Milestone

Comments

@dminor
Copy link
Contributor

dminor commented Jun 22, 2021

According to test262, the likely subtags minimize operation applied to und should result in en.

To work on this bug:

[1] https://github.com/tc39/test262/blob/main/test/intl402/Locale/prototype/minimize/removing-likely-subtags-first-adds-likely-subtags.js#L23

@dminor dminor added T-bug Type: Bad behavior, security, privacy good first issue Good for newcomers C-locale Component: Locale identifiers, BCP47 A-scope Area: Project scope, feature coverage S-small Size: One afternoon (small bug fix or enhancement) labels Jun 22, 2021
@dminor dminor added this to the ICU4X 1.0 milestone Jun 22, 2021
@himanshu007-creator
Copy link

Hi, i would like to work on this issue. Please guide me what needs to be done as i am new here. Thanks

@dminor
Copy link
Contributor Author

dminor commented Jun 24, 2021

Hi, thanks for offering to help! I'm not sure I can give much guidance beyond what I wrote down above. I think there's an algorithmic error in our implementation, so I'd suggest adding a failing test case, and comparing what is happening in our code to the description in https://www.unicode.org/reports/tr35/#Likely_Subtags.

@sffc
Copy link
Member

sffc commented Oct 1, 2021

@samchen61661 is interested in working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-scope Area: Project scope, feature coverage C-locale Component: Locale identifiers, BCP47 good first issue Good for newcomers S-small Size: One afternoon (small bug fix or enhancement) T-bug Type: Bad behavior, security, privacy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants