Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-static blobs in icu_provider_blob #848

Closed
Tracked by #873
sffc opened this issue Jul 4, 2021 · 0 comments · Fixed by #1084
Closed
Tracked by #873

Support non-static blobs in icu_provider_blob #848

sffc opened this issue Jul 4, 2021 · 0 comments · Fixed by #1084
Assignees
@sffc
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Milestone
2021 Q3 0.4 Sprint C

Comments

@sffc
Copy link
Member

sffc commented Jul 4, 2021

Currently the icu_provider_blob crate exports StaticDataProvider. We should generalize this class to support blob data loaded at runtime. Consider making StaticDataProvider a special case of the more general BlobDataProvider.

Depends on #752
@sffc sffc added T-core Type: Required functionality C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) labels Jul 4, 2021
@sffc sffc added this to the ICU4X 0.4 milestone Jul 4, 2021
@sffc sffc self-assigned this Jul 4, 2021
@sffc sffc mentioned this issue Jul 4, 2021
Merged
@sffc sffc added the blocked A dependency must be resolved before this is actionable label Jul 13, 2021
@sffc sffc mentioned this issue Jul 13, 2021
Closed
@sffc sffc mentioned this issue Jul 21, 2021
Closed
7 tasks
@sffc sffc modified the milestones: ICU4X 0.4, 2021 Q3 0.4 Sprint B Aug 11, 2021
@sffc sffc mentioned this issue Sep 1, 2021
Closed
@sffc sffc removed the blocked A dependency must be resolved before this is actionable label Sep 8, 2021
@sffc sffc mentioned this issue Sep 16, 2021
Merged
@sffc sffc linked a pull request Sep 30, 2021 that will close this issue
Adding BlobDataProvider for dynamically loaded data blobs #1084
Merged
@sffc sffc closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
2021 Q3 0.4 Sprint C
Development

Successfully merging a pull request may close this issue.

Adding BlobDataProvider for dynamically loaded data blobs sffc/omnicu
1 participant
@sffc