Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pinned nightly #977

Closed
Manishearth opened this issue Aug 25, 2021 · 4 comments · Fixed by #1010
Closed

Update pinned nightly #977

Manishearth opened this issue Aug 25, 2021 · 4 comments · Fixed by #1010
Assignees
@Manishearth
Labels
A-ffi Area: FFI, WebAssembly, Transpilation C-ffi-infra Component: Diplomat, horizontal FFI C-test-infra Component: Integration test infrastructure S-small Size: One afternoon (small bug fix or enhancement) T-docs-tests Type: Code change outside core library
Milestone
2021 Q3 0.4 Sprint A

Comments

@Manishearth
Copy link
Member

From #968 (comment)

We pin nightly-2021-02-28 in CI for WASM/FFI testing so that our usage of nightly features doesn't suddenly break. We'll eventually want to bump it (especially once rust-lang/rust#85499 lands, fixing a lot of the compiler bugs plaguing yoke). It's good if we can update it to something recent.

At the moment the WASM build fails with things like

    error: WASM error: Invalid name type (at offset 18707)

..

unknown name subsection at 1187412
unknown name subsection at 1187432

Searching around this seems fixable; we should figure out what's wrong and fix it so we can use a newer nightly.
@Manishearth Manishearth added help wanted Issue needs an assignee C-test-infra Component: Integration test infrastructure C-ffi-infra Component: Diplomat, horizontal FFI labels Aug 25, 2021
@sffc sffc added A-ffi Area: FFI, WebAssembly, Transpilation question Unresolved questions; type unclear T-docs-tests Type: Code change outside core library labels Aug 25, 2021
@Manishearth
Copy link
Member Author

Bisected to 476acbf1e..45b3c2851 in rustc (2021-03-04 to 2021-03-05). This is quite likely due to the LLVM upgrade.

@Manishearth
Copy link
Member Author

I also found WebAssembly/binaryen#1914

@Manishearth
Copy link
Member Author

So there were two errors. The "invalid name type" is an error originating from the wasmparser crate. The code producing that error has since been updated to handle more cases, so I think twiggy needs to be updated to the latest wasmparser.

The other error happened in the binarysize job, haven't investigated that yet.

@Manishearth
Copy link
Member Author

Manishearth commented Aug 26, 2021 •
edited
Loading

The twiggy bug is addressed by using rustwasm/twiggy#576 . It hasn't been released yet but should be soon. In the meantime we can install from git.

@Manishearth Manishearth mentioned this issue Aug 26, 2021
Merged
@sffc sffc removed the help wanted Issue needs an assignee label Aug 26, 2021
@sffc sffc added this to the 2021 Q3 0.4 Sprint A milestone Aug 26, 2021
@sffc sffc added S-small Size: One afternoon (small bug fix or enhancement) and removed question Unresolved questions; type unclear labels Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-ffi Area: FFI, WebAssembly, Transpilation C-ffi-infra Component: Diplomat, horizontal FFI C-test-infra Component: Integration test infrastructure S-small Size: One afternoon (small bug fix or enhancement) T-docs-tests Type: Code change outside core library
Projects
None yet
Milestone
2021 Q3 0.4 Sprint A
Development

Successfully merging a pull request may close this issue.

Update pinned nightly Manishearth/icu4x
2 participants
@sffc @Manishearth