Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Format - Test Suite #109

Closed
romulocintra opened this issue Aug 17, 2020 · 4 comments · Fixed by #604
Closed

Message Format - Test Suite #109

romulocintra opened this issue Aug 17, 2020 · 4 comments · Fixed by #604
Assignees
Labels
blocker-candidate The submitter thinks this might be a block for the Technology Preview LDML45 LDML45 Release (Tech Preview)

Comments

@romulocintra
Copy link
Collaborator

We should have a group of standard sentences that could be used as a test cases for all possible implementations of message format. They must cover all possible casuistics

We have an example here for selectors.

@romulocintra
Copy link
Collaborator Author

Unfortunately i cannot assign it to you @grhoten , not sure why. but here is the issue we talked about.👍

@eemeli
Copy link
Collaborator

eemeli commented Apr 19, 2021

As mentioned during the meeting, the test suite for the messageformat npm library is pretty extensive, and relatively portable: https://github.com/messageformat/messageformat/tree/master/test/fixtures

The test fixtures are stored as TS in order to make it easier to generate some of them programmatically and to define a few of the custom formatters, but it'd be pretty straightforward to transform them to a different format. The tests are published under the MIT license, and are therefore pretty free to use.

As the sources for these tests are in MF1, they'll need to be transformed to an MF2 data model either live or as a pre-stage in order to test layers built on top of that.

@romulocintra
Copy link
Collaborator Author

Referencig #165 (comment) , cause is a great start to design and plan how test suite should work and is already functional.

My ideia here is to isolate the data source and have a group of generic test value(inputs/expected results), to be reused across different implementations of the MF (something like this independent of the final format) or we can start as we here and choose the format later

@romulocintra romulocintra added this to the A conformance test suite for parsing and formatting messages. milestone Oct 13, 2021
@eemeli eemeli added the blocker-candidate The submitter thinks this might be a block for the Technology Preview label Jan 23, 2023
@eemeli
Copy link
Collaborator

eemeli commented Jan 23, 2023

Nominating this as a blocker, as the test suite is explicitly listed as one of our deliverables.

@eemeli eemeli self-assigned this Jan 15, 2024
@eemeli eemeli added the LDML45 LDML45 Release (Tech Preview) label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker-candidate The submitter thinks this might be a block for the Technology Preview LDML45 LDML45 Release (Tech Preview)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants