Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kPhonetic 1188 #72

Closed
paulmasson opened this issue Feb 28, 2024 · 3 comments
Closed

kPhonetic 1188 #72

paulmasson opened this issue Feb 28, 2024 · 3 comments

Comments

@paulmasson
Copy link
Contributor

Pull request #71 is a first pass at this group. There will be at least a couple other pull requests to clean up this group. Doing this in stages.
@paulmasson paulmasson mentioned this issue Feb 28, 2024
Open
@paulmasson
Copy link
Contributor Author

Two more pull requests: #75 and #76.

@paulmasson
Copy link
Contributor Author

This group now has 10 characters and 6 additions, as can be seen with this link:

https://analyticphysics.com/Language/Chinese Phonetic Groups.htm?current=1188&highlight

I can see no compelling reason to place the remaining additions in other groups, and propose leaving them as is for now. If that is satisfactory, then please indicate by closing this issue.

@kenlunde
Copy link
Member

kenlunde commented Mar 1, 2024

LGTM

@kenlunde kenlunde closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmasson @kenlunde