Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smooth attribute in point element is unclear #209

Open
drj11 opened this issue Jun 3, 2022 · 4 comments
Open

smooth attribute in point element is unclear #209

drj11 opened this issue Jun 3, 2022 · 4 comments

Comments

@drj11
Copy link

drj11 commented Jun 3, 2022

Refer to https://unifiedfontobject.org/versions/ufo3/glyphs/glif/#point

The text is:

This attribute must only be given when type indicates the point is on-curve. When set to yes, it signifies that a smooth curvature should be maintained at this point, either as a curve point or a tangent point in Fontographer terms. This attribute may be set for all point types except offcurve.

  • Referring to Fontographer is bad. Especially for those of us that have never used it.
  • The way "curvature" is used here can't be consistent with its usual mathematical sense.

I expect the intention is that the curve's tangent going into the point is the same as the curve's tangent leaving the point. This is not the same as a smooth curvature.

Can we say that:

"When set to yes, it signifies that the curve is smooth at this point: the tangent entering the point is the same as the tangent leaving the point. This means that the previous point, this point, and the next point are colinear (up to the chosen precision)."

@justvanrossum
Copy link
Contributor

It is purely a flag for edit behavior. It doesn't necessarily say the curve is smooth at this point, but rather that an editor should try to constrain the surrounding handle(s) to keep/make smoothness.

But yes, a better formulation here is definitely a good idea.

@drj11
Copy link
Author

drj11 commented Jun 3, 2022

if you're fine with "this is a flag used by willing editors" then so am i. ;)

@justvanrossum
Copy link
Contributor

While we're nitpicking: the flag only makes sense on an on-curve point with at least one off-curve neighbor. It is meaningless if both neighbors are on-curve.

@drj11
Copy link
Author

drj11 commented Jun 3, 2022

Yep. I did pick that up in my reading, but even i have only a certain budget for nitpicking. But also the UFO spec has plenty of room for people to create meaningless UFO files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants