Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make meta not optional #10

Merged
merged 1 commit into from
Apr 1, 2018
Merged

fix: make meta not optional #10

merged 1 commit into from
Apr 1, 2018

Conversation

unional
Copy link
Collaborator

@unional unional commented Apr 1, 2018

While technically meta can be undefined when not used (to save space).
Making it optional means every time you use it you need to check if it is undefined.

And since you use it, you assume that your specific action will have meta defined.

The same argument as redux-utilities/flux-standard-action#53

While technically meta can be undefined when not used (to save space).
Making it optional means every time you use it you need to check if it is undefined.

And since you use it, you assume that your specific action will have meta defined.

The same argument as redux-utilities/flux-standard-action#53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 30

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 29: 0.0%
Covered Lines: 13
Relevant Lines: 13

💛 - Coveralls

@codecov
Copy link

codecov bot commented Apr 1, 2018

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          13     13           
  Branches        2      2           
=====================================
  Hits           13     13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c90d5...499591f. Read the comment docs.

@unional unional merged commit 4859f0d into master Apr 1, 2018
@unional unional deleted the ,eta branch April 1, 2018 03:44
@unional
Copy link
Collaborator Author

unional commented Apr 1, 2018

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants