Investigate adding nilaway check to CI

[benluelo]

https://github.com/uber-go/nilaway

looks interesting

https://search.nixos.org/packages?channel=24.05&show=nilaway&from=0&size=50&sort=relevance&type=packages&query=nilaway

[PoisonPhang]

nilaway recommends using another driver rather than running the linter directly, one of the recommended drivers is golangci-lint.

For the uniond go project, we already run staticcheck on it's own. golangci-lint would allow us to run both staticcheck, nilaway, and more. It would also take advantage of go/analysis.

[PoisonPhang]

NilAway is currently under active development: false positives and breaking changes can happen. We highly appreciate any feedback and contributions!

NilAway, in its current form, can report false positives. This unfortunately hinders its immediate merging in golangci-lint and be offered as a linter (see golangci/golangci-lint#4045). Therefore, you need to build NilAway as a plugin to golangci-lint to be executed as a private linter. There are two plugin systems in golangci-lint, and it is much easier to use the Module Plugin System (introduced since v1.57.0), and it is the only supported approach to run NilAway in golangci-lint.

I'll keep tabs on nilaway in the future. In it's current state, I don't think nilaway is ready for use in CI