Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more flexible config format #12

Closed
paalbra opened this issue Jun 15, 2020 · 4 comments · Fixed by #39
Closed

Use a more flexible config format #12

paalbra opened this issue Jun 15, 2020 · 4 comments · Fixed by #39
Assignees
@paalbra
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@paalbra
Copy link
Contributor

paalbra commented Jun 15, 2020

Switch to something more flexible than the INI format for config.

Maybe YAML, JSON or TOML.
@paalbra paalbra added the enhancement New feature or request label Jun 15, 2020
@paalbra paalbra added the good first issue Good for newcomers label Jul 3, 2020
@paalbra
Copy link
Contributor Author

paalbra commented Jul 3, 2020

YAML might be the best choice right now, but I believe it's worth looking into how TOML is received in v1.0 (currently v1.0.0-rc.1):

https://github.com/toml-lang/toml

Zabbix-auto-config itself might not benefit much from switching from ini, but the source collectors could have a simpler config if using other formats.

@paalbra paalbra self-assigned this Dec 19, 2021
@paalbra
Copy link
Contributor Author

paalbra commented Dec 19, 2021

TOML seems like a good choice, but it's currently not obvious which library to choose. Looks like others might be leaning towards tomli

@mbakke
Copy link
Contributor

mbakke commented Dec 20, 2021

TOML and tomli seem like fine options to me.

@paalbra paalbra mentioned this issue Feb 5, 2022
Merged
@paalbra
Copy link
Contributor Author

paalbra commented Feb 5, 2022

tomli seems like a good choice. People have been working to propose it as a stdlib module: hukkin/tomli#141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paalbra paalbra

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance config format unioslo/zabbix-auto-config
2 participants
@paalbra @mbakke